From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 01/11] eth: move queue check for rx_queue_count
Date: Sun, 26 Jul 2015 15:47:25 +0200 [thread overview]
Message-ID: <5715009.9JOkuqddi2@xps13> (raw)
In-Reply-To: <1437757584-15502-2-git-send-email-stephen@networkplumber.org>
2015-07-24 10:06, Stephen Hemminger:
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -122,6 +122,7 @@
> } \
> } while (0)
>
> +
checkpatch would warn about this whitespace change
> static const char *MZ_RTE_ETH_DEV_DATA = "rte_eth_dev_data";
> struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
> static struct rte_eth_dev_data *rte_eth_dev_data;
> @@ -2910,6 +2911,11 @@ rte_eth_rx_queue_count(uint8_t port_id, uint16_t queue_id)
>
> VALID_PORTID_OR_ERR_RET(port_id, 0);
>
> + if (queue_id >= dev->data->nb_rx_queues) {
> + PMD_RX_LOG(ERR, "Invalid RX queue id=%d", queue_id);
> + return 0;
> + }
PMD_RX_LOG is not defined in ethdev.
next prev parent reply other threads:[~2015-07-26 13:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 17:06 [dpdk-dev] [PATCH 00/11] misc cleanup patches Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 01/11] eth: move queue check for rx_queue_count Stephen Hemminger
2015-07-26 13:47 ` Thomas Monjalon [this message]
2015-08-03 17:00 ` Zhang, Helin
2015-07-24 17:06 ` [dpdk-dev] [PATCH 02/11] eth: do simple return Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 03/11] kni: remove useless semicolon Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 04/11] eth: remove unnecessary return value Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 05/11] kni: eliminate unnecessary return variables Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 06/11] pipeline: remove useless cast Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 07/11] lpm: remove useless casts Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 08/11] hash: " Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 09/11] kni: remove useless cast Stephen Hemminger
2015-07-24 17:06 ` [dpdk-dev] [PATCH 10/11] i40e: " Stephen Hemminger
2015-08-03 16:56 ` Zhang, Helin
2015-07-24 17:06 ` [dpdk-dev] [PATCH 11/11] bond: " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5715009.9JOkuqddi2@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).