* [dpdk-dev] Pktgen rate issue
@ 2016-04-12 8:25 Iñaki Murillo
2016-04-12 12:55 ` Wiles, Keith
0 siblings, 1 reply; 5+ messages in thread
From: Iñaki Murillo @ 2016-04-12 8:25 UTC (permalink / raw)
To: dev
Hello
I have been using pktgen for a while and I released that there is no
possibility to set a rate between two whole numbers.
I looked up the source code and I found out that the rate is stored in
a uint8_t. So, I made a quick-and-dirty change just to check if it is
possible to get a speed between two hole numbers. It seemed to work
properly.
Is there a reason to use an uint8_t instead of a float, for example?
Thank you,
Iñaki Murillo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] Pktgen rate issue
2016-04-12 8:25 [dpdk-dev] Pktgen rate issue Iñaki Murillo
@ 2016-04-12 12:55 ` Wiles, Keith
2016-04-21 14:22 ` Iñaki Murillo
0 siblings, 1 reply; 5+ messages in thread
From: Wiles, Keith @ 2016-04-12 12:55 UTC (permalink / raw)
To: Iñaki Murillo, dev
>Hello
>
>I have been using pktgen for a while and I released that there is no
>possibility to set a rate between two whole numbers.
>
> I looked up the source code and I found out that the rate is stored in
>a uint8_t. So, I made a quick-and-dirty change just to check if it is
>possible to get a speed between two hole numbers. It seemed to work
>properly.
>
> Is there a reason to use an uint8_t instead of a float, for example?
The uint8_t was easier then using floats :-)
If you have a patch for this change please send it along and I will look at adding the support.
>
>Thank you,
>
>Iñaki Murillo
>
Regards,
Keith
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] Pktgen rate issue
2016-04-12 12:55 ` Wiles, Keith
@ 2016-04-21 14:22 ` Iñaki Murillo
2016-04-21 14:28 ` Wiles, Keith
0 siblings, 1 reply; 5+ messages in thread
From: Iñaki Murillo @ 2016-04-21 14:22 UTC (permalink / raw)
To: Wiles, Keith, dev
Hello Keith,
I have done a patch to the pktgen, but I not sure how to submit it. I
would be very grateful if you give me some advice on how to contribute.
Thank you,
Iñaki Murillo
El 12/04/16 a las 14:55, Wiles, Keith escribió:
>> Hello
>>
>> I have been using pktgen for a while and I released that there is no
>> possibility to set a rate between two whole numbers.
>>
>> I looked up the source code and I found out that the rate is stored in
>> a uint8_t. So, I made a quick-and-dirty change just to check if it is
>> possible to get a speed between two hole numbers. It seemed to work
>> properly.
>>
>> Is there a reason to use an uint8_t instead of a float, for example?
> The uint8_t was easier then using floats :-)
>
> If you have a patch for this change please send it along and I will look at adding the support.
>
>> Thank you,
>>
>> Iñaki Murillo
>>
>
> Regards,
> Keith
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] Pktgen rate issue
2016-04-21 14:22 ` Iñaki Murillo
@ 2016-04-21 14:28 ` Wiles, Keith
2016-04-21 15:41 ` Iñaki Murillo
0 siblings, 1 reply; 5+ messages in thread
From: Wiles, Keith @ 2016-04-21 14:28 UTC (permalink / raw)
To: Iñaki Murillo, dev
>Hello Keith,
>
>I have done a patch to the pktgen, but I not sure how to submit it. I
>would be very grateful if you give me some advice on how to contribute.
Please have a look at the DPDK.org page on development : http://dpdk.org/dev
You could send me the patch on the current Pktgen and I can review the changes.
>
>Thank you,
>
> Iñaki Murillo
>
>El 12/04/16 a las 14:55, Wiles, Keith escribió:
>>> Hello
>>>
>>> I have been using pktgen for a while and I released that there is no
>>> possibility to set a rate between two whole numbers.
>>>
>>> I looked up the source code and I found out that the rate is stored in
>>> a uint8_t. So, I made a quick-and-dirty change just to check if it is
>>> possible to get a speed between two hole numbers. It seemed to work
>>> properly.
>>>
>>> Is there a reason to use an uint8_t instead of a float, for example?
>> The uint8_t was easier then using floats :-)
>>
>> If you have a patch for this change please send it along and I will look at adding the support.
>>
>>> Thank you,
>>>
>>> Iñaki Murillo
>>>
>>
>> Regards,
>> Keith
>>
>>
>>
>>
>
>
Regards,
Keith
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] Pktgen rate issue
2016-04-21 14:28 ` Wiles, Keith
@ 2016-04-21 15:41 ` Iñaki Murillo
0 siblings, 0 replies; 5+ messages in thread
From: Iñaki Murillo @ 2016-04-21 15:41 UTC (permalink / raw)
To: Wiles, Keith, dev
Hello Keith,
I sent the patch as it is described in http://dpdk.org/dev but I got
confused and I did not put that it was a patch for Pktgen. I hope it
does not make anyone get confused.
Thank you,
Iñaki Murillo
El 21/04/16 a las 16:28, Wiles, Keith escribió:
>> Hello Keith,
>>
>> I have done a patch to the pktgen, but I not sure how to submit it. I
>> would be very grateful if you give me some advice on how to contribute.
> Please have a look at the DPDK.org page on development : http://dpdk.org/dev
>
> You could send me the patch on the current Pktgen and I can review the changes.
>
>> Thank you,
>>
>> Iñaki Murillo
>>
>> El 12/04/16 a las 14:55, Wiles, Keith escribió:
>>>> Hello
>>>>
>>>> I have been using pktgen for a while and I released that there is no
>>>> possibility to set a rate between two whole numbers.
>>>>
>>>> I looked up the source code and I found out that the rate is stored in
>>>> a uint8_t. So, I made a quick-and-dirty change just to check if it is
>>>> possible to get a speed between two hole numbers. It seemed to work
>>>> properly.
>>>>
>>>> Is there a reason to use an uint8_t instead of a float, for example?
>>> The uint8_t was easier then using floats :-)
>>>
>>> If you have a patch for this change please send it along and I will look at adding the support.
>>>
>>>> Thank you,
>>>>
>>>> Iñaki Murillo
>>>>
>>> Regards,
>>> Keith
>>>
>>>
>>>
>>>
>>
>
> Regards,
> Keith
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-21 15:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-12 8:25 [dpdk-dev] Pktgen rate issue Iñaki Murillo
2016-04-12 12:55 ` Wiles, Keith
2016-04-21 14:22 ` Iñaki Murillo
2016-04-21 14:28 ` Wiles, Keith
2016-04-21 15:41 ` Iñaki Murillo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).