From: "Iñaki Murillo" <inaki.murilloa@ehu.eus>
To: "Wiles, Keith" <keith.wiles@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Pktgen rate issue
Date: Thu, 21 Apr 2016 17:41:36 +0200 [thread overview]
Message-ID: <5718F4B0.6020208@ehu.eus> (raw)
In-Reply-To: <E2498F04-AC7B-4ECD-8236-23CDDEF16DD3@intel.com>
Hello Keith,
I sent the patch as it is described in http://dpdk.org/dev but I got
confused and I did not put that it was a patch for Pktgen. I hope it
does not make anyone get confused.
Thank you,
Iñaki Murillo
El 21/04/16 a las 16:28, Wiles, Keith escribió:
>> Hello Keith,
>>
>> I have done a patch to the pktgen, but I not sure how to submit it. I
>> would be very grateful if you give me some advice on how to contribute.
> Please have a look at the DPDK.org page on development : http://dpdk.org/dev
>
> You could send me the patch on the current Pktgen and I can review the changes.
>
>> Thank you,
>>
>> Iñaki Murillo
>>
>> El 12/04/16 a las 14:55, Wiles, Keith escribió:
>>>> Hello
>>>>
>>>> I have been using pktgen for a while and I released that there is no
>>>> possibility to set a rate between two whole numbers.
>>>>
>>>> I looked up the source code and I found out that the rate is stored in
>>>> a uint8_t. So, I made a quick-and-dirty change just to check if it is
>>>> possible to get a speed between two hole numbers. It seemed to work
>>>> properly.
>>>>
>>>> Is there a reason to use an uint8_t instead of a float, for example?
>>> The uint8_t was easier then using floats :-)
>>>
>>> If you have a patch for this change please send it along and I will look at adding the support.
>>>
>>>> Thank you,
>>>>
>>>> Iñaki Murillo
>>>>
>>> Regards,
>>> Keith
>>>
>>>
>>>
>>>
>>
>
> Regards,
> Keith
>
>
>
>
prev parent reply other threads:[~2016-04-21 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 8:25 Iñaki Murillo
2016-04-12 12:55 ` Wiles, Keith
2016-04-21 14:22 ` Iñaki Murillo
2016-04-21 14:28 ` Wiles, Keith
2016-04-21 15:41 ` Iñaki Murillo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5718F4B0.6020208@ehu.eus \
--to=inaki.murilloa@ehu.eus \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).