From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.ehu.eus (smtp.lg.ehu.es [158.227.0.66]) by dpdk.org (Postfix) with ESMTP id 9553639EA for ; Thu, 21 Apr 2016 17:42:42 +0200 (CEST) Received: from smtp.ehu.eus (localhost.localdomain [127.0.0.1]) by postfix.imss71 (Postfix) with ESMTP id B94FC8F67; Thu, 21 Apr 2016 17:42:41 +0200 (CEST) Received: from [158.227.98.37] (unknown [158.227.98.37]) by smtp2 (Postfix) with ESMTPSA id 765876E90; Thu, 21 Apr 2016 17:42:41 +0200 (CEST) To: "Wiles, Keith" , "dev@dpdk.org" References: <570CB0E3.7010709@ehu.eus> <5718E214.3000209@ehu.eus> From: =?UTF-8?Q?I=c3=b1aki_Murillo?= Message-ID: <5718F4B0.6020208@ehu.eus> Date: Thu, 21 Apr 2016 17:41:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4 (smtp2); Thu, 21 Apr 2016 17:42:41 +0200 (CEST) X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22276.000 X-TM-AS-Result: No--11.074-7.0-31-1 X-imss-scan-details: No--11.074-7.0-31-1 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4 (postfix.imss71); Thu, 21 Apr 2016 17:42:42 +0200 (CEST) Subject: Re: [dpdk-dev] Pktgen rate issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2016 15:42:42 -0000 Hello Keith, I sent the patch as it is described in http://dpdk.org/dev but I got confused and I did not put that it was a patch for Pktgen. I hope it does not make anyone get confused. Thank you, Iñaki Murillo El 21/04/16 a las 16:28, Wiles, Keith escribió: >> Hello Keith, >> >> I have done a patch to the pktgen, but I not sure how to submit it. I >> would be very grateful if you give me some advice on how to contribute. > Please have a look at the DPDK.org page on development : http://dpdk.org/dev > > You could send me the patch on the current Pktgen and I can review the changes. > >> Thank you, >> >> Iñaki Murillo >> >> El 12/04/16 a las 14:55, Wiles, Keith escribió: >>>> Hello >>>> >>>> I have been using pktgen for a while and I released that there is no >>>> possibility to set a rate between two whole numbers. >>>> >>>> I looked up the source code and I found out that the rate is stored in >>>> a uint8_t. So, I made a quick-and-dirty change just to check if it is >>>> possible to get a speed between two hole numbers. It seemed to work >>>> properly. >>>> >>>> Is there a reason to use an uint8_t instead of a float, for example? >>> The uint8_t was easier then using floats :-) >>> >>> If you have a patch for this change please send it along and I will look at adding the support. >>> >>>> Thank you, >>>> >>>> Iñaki Murillo >>>> >>> Regards, >>> Keith >>> >>> >>> >>> >> > > Regards, > Keith > > > >