From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 580181BBE for ; Mon, 25 Apr 2016 11:44:56 +0200 (CEST) Received: by mail-pa0-f48.google.com with SMTP id r5so56479417pag.1 for ; Mon, 25 Apr 2016 02:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=j1X/OHzzgDedA9NL4qx0cuQPooMHlZFQKNjxu4e9Lls=; b=NF35q/n+l3g8m7HfArnwlK6XKjb/abjwkEfg7NSsqI+A80WZzZGmzJ/heMfonaj3Z/ +7GNcib0RwkTQWwPwr99na2jDL4ntYhAP37CUe4a8Og02g2xiNcwrUTPGlN8lr4GW6rK A3YGT09h4kgzECwDt+oMPX08vC4tXhJ8y963hIGuyoJbWoVntGEm23GSZY5InHKh/8gz cRBgKF9nl1WiPS6mhreSuRuVOJZPwi+zhfvzcfjvO66skCzp9BxdEO7Ji3xsUmi89/iH 9y0Ev28z9XA9XL9J1UhEE17JqntLiUt653Qs+EbZX7D0UKR0nNj6jw7x5OnhPMiOSN6X 9Kog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=j1X/OHzzgDedA9NL4qx0cuQPooMHlZFQKNjxu4e9Lls=; b=ZHj9lQB8aclOePwgvaO+pKQHSn0wkYNBf3vApFvrQJFVPYFyYzptLdmFyNpCuDx+m9 JNdegjlJKAm52BWiXIVn9mW3wV9izCOl5RwX2+pzWBl8h+nXR0ivcJQOME2RlsKfl6Oc H09535ql+tWcIW/70zyG6yI3L3DbaoH/SJg+pLeUz2Fm8Vj2U6N1qmN/b7YqaG1diTlm EEIUrpz9RD/2nPxoUQrwO2pWvqPfLYjsraWv8Zi28cJ6iSd/4TY4Ipq1JV6g8xkwW28V 801/On9ovaGuc3mM5iHhO2nfLUObrlc2PcEEeDkknFL2fBeR78UJWd39gVGlxumEn1+Q w+UQ== X-Gm-Message-State: AOPr4FVlZuKro+vR6nldasvQToGRCPitbETFUml52bUS5KyQz3ZFyB0YPICNyNWHZlgzmQ== X-Received: by 10.66.66.108 with SMTP id e12mr47457623pat.92.1461577495724; Mon, 25 Apr 2016 02:44:55 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id zn12sm10124192pab.14.2016.04.25.02.44.53 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 25 Apr 2016 02:44:54 -0700 (PDT) To: Panu Matilainen , "dev@dpdk.org" References: <571DDDD8.6000000@igel.co.jp> <571DE345.4000609@redhat.com> Cc: Yuanhan Liu , "Xie, Huawei" From: Tetsuya Mukawa Message-ID: <571DE714.9050402@igel.co.jp> Date: Mon, 25 Apr 2016 18:44:52 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <571DE345.4000609@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2016 09:44:56 -0000 On 2016/04/25 18:28, Panu Matilainen wrote: > On 04/25/2016 12:05 PM, Tetsuya Mukawa wrote: >> Hi Yuanhan, >> >> I want to apply a patch to vhost PMD. >> Before submitting, could you please let me know your guess about the >> patch? >> >> Here is my problem. >> I am using below shared library configuration to build my application. >> CONFIG_RTE_BUILD_SHARED_LIB=y >> Normally, My application doesn't need vhost facilities, so librte_vhost >> isn't linked while compiling. >> >> Sometimes, I need to use vhost PMD, so I just want to add '-d >> librte_pmd_vhost.so' to DPDK command line to load vhost PMD library. >> But my application doesn't have librte_vhost, then I've got an error >> about it. >> Even if specify like "-d librte_vhost -d librte_pmd_vhost", I still have >> an error. >> Probably this is because above libraries will be dlopen(ed) with >> RTLD_LOCAL option. >> >> Here, I have 2 choices. >> One is linking librte_vhost to my application while compiling, even if I >> don't need it normally. >> This is the way all DPDK examples did. But I am wondering if I should >> follow this. >> >> Another way is applying a below patch. >> --- a/drivers/net/vhost/Makefile >> +++ b/drivers/net/vhost/Makefile >> @@ -38,6 +38,7 @@ LIB = librte_pmd_vhost.a >> >> CFLAGS += -O3 >> CFLAGS += $(WERROR_FLAGS) >> +LDLIBS += -lrte_vhost >> >> EXPORT_MAP := rte_pmd_vhost_version.map >> >> This is same way to link libpcap to librte_pmd_pcap. >> What do you think about adding it to vhost PMD? > > Yes, this is absolutely the right thing to do. > > Ultimately this should be done for all dependencies in all libraries, > but missing dependencies are even more pronounced in plugins so the > sooner this goes in, the better. > > Acked-by: Panu Matilainen > > - Panu - Hi Panu, I appreciate your comment. I will send it as a patch tomorrow. It seems I cannot connect to DPDK git repository so far. So I cannot test it with latest code. Thanks, Tetsuya > > >> >> Thanks, >> Tetsuya >> >