From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 106E82BC6 for ; Tue, 26 Apr 2016 04:00:04 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 25 Apr 2016 19:00:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,535,1455004800"; d="scan'208,217";a="966424057" Received: from shwde7554.ccr.corp.intel.com (HELO [10.239.67.73]) ([10.239.67.73]) by fmsmga002.fm.intel.com with ESMTP; 25 Apr 2016 19:00:03 -0700 To: "Xing, Beilei" References: <1461410769-16942-1-git-send-email-beilei.xing@intel.com> Cc: "dev@dpdk.org" From: "Wu, Jingjing" Message-ID: <571ECBA3.6010409@intel.com> Date: Tue, 26 Apr 2016 10:00:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461410769-16942-1-git-send-email-beilei.xing@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] i40e: configure MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 02:00:05 -0000 On 4/23/2016 7:26 PM, Xing, Beilei wrote: > This patch enables configuring MTU for i40e. > Since changing MTU needs to reconfigure queue, stop port first > before configuring MTU. > > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_ethdev.c | 49 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index bc28d3c..29259b9 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -447,6 +447,8 @@ static int i40e_get_eeprom(struct rte_eth_dev *dev, > static void i40e_set_default_mac_addr(struct rte_eth_dev *dev, > struct ether_addr *mac_addr); > > +static int i40e_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); > + > static const struct rte_pci_id pci_id_i40e_map[] = { > #define RTE_PCI_DEV_ID_DECL_I40E(vend, dev) {RTE_PCI_DEVICE(vend, dev)}, > #include "rte_pci_dev_ids.h" > @@ -520,6 +522,7 @@ static const struct eth_dev_ops i40e_eth_dev_ops = { > .get_eeprom_length = i40e_get_eeprom_length, > .get_eeprom = i40e_get_eeprom, > .mac_addr_set = i40e_set_default_mac_addr, > + .mtu_set = i40e_dev_mtu_set, > }; > > /* store statistics names and its offset in stats structure */ > @@ -9104,3 +9107,49 @@ static void i40e_set_default_mac_addr(struct rte_eth_dev *dev, > /* Flags: 0x3 updates port address */ > i40e_aq_mac_address_write(hw, 0x3, mac_addr->addr_bytes, NULL); > } > + > +static int i40e_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) According to the coding style, at function definition, "The function type should be on a line by itself preceding the function." > +{ > + struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > + struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + struct rte_eth_dev_data *dev_data = pf->dev_data; > + struct rte_eth_dev_info dev_info; > + struct i40e_rx_queue *rxq; > + int i; > + uint16_t len; > + uint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN; > + int ret = 0; > + > + i40e_dev_info_get(dev, &dev_info); > + > + /* check if mtu is within the allowed range */ > + if ((mtu < ETHER_MIN_MTU) || (frame_size > dev_info.max_rx_pktlen)) > + return -EINVAL; > + The dev_info.max_rx_pktlen queried by i40e_dev_info_get is "I40E_FRAME_SIZE_MAX". No need to call the API to get dev info in driver.