From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id CC60EB62 for ; Tue, 26 Apr 2016 07:37:40 +0200 (CEST) Received: by mail-pf0-f179.google.com with SMTP id 206so2477085pfu.0 for ; Mon, 25 Apr 2016 22:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=kZTvRXVC2L0dMMPj3kpGHvNawuuBB2BcdfsfI8vevFo=; b=sg346zDMYw1VVmMPe1EJ8c5ZPEA/MVgcoPEev37ZfGwMnMrSsquwqIaC7mGFre+5e+ MUxuVxkMvZU2EvfztuEkwjW3lfrSgzriWrFdhqh886UX9l6JKBtbIvd1jAjI2UOJdjp2 89lZnaBzYWz5qlptbLd/XX0J/6SYPJg3Qy+eFJvAf1wYbhh99OPYTyVaCEBSv9YJaZF1 ygERGzUylud7lFDaAtVEgk76oybsvCRE8BvYLeFIdKim9yFrWqYwhPZMEUVrLclaUfzZ fXUa0s0l3tobHr4JLXOlI7ltvcsifHhg92rL7y8d5wXi0sJxNkirSkgtNt6uHMYOvWhR 1/0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=kZTvRXVC2L0dMMPj3kpGHvNawuuBB2BcdfsfI8vevFo=; b=MouwAiq0+XG4rKMnaZ6LQUH/LR2JHojNTTHe18X90Z3snxqD/pyZwb4qYMpw6FDltk lJYuMk6QOL5Rr7KMnc7EtlDtryFgQmzJnAI6ZZU5CT5e+msvkVKW1UQ/W6bdF3NWHBS3 8+4F7hMMeiA6Bh5yI4wLMJiBrboBwuM+kisBl4VcMbrtpaH124vuGELS1t/dxnC7B3u1 W8m7S6Usivjq1gmPUFGVT1X2yLQC7ktFRNseL6ZaH7O0S1IpYP6nBUWsFmk/N8mTFgUG VQBv3ayzNdNLYn0RRYNuC10Xj3cDmQEhKQaXKonm3soZQAcJFULIBGz/MPc40kKxZq1q UCAA== X-Gm-Message-State: AOPr4FVl6OghxCs0e6Xj2X5fb1R89mOfghAo/S32S84rf7hu7crhAo/+JfuARgwNhm0lIw== X-Received: by 10.98.26.205 with SMTP id a196mr970165pfa.46.1461649060123; Mon, 25 Apr 2016 22:37:40 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id 82sm33130718pfb.64.2016.04.25.22.37.38 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 25 Apr 2016 22:37:39 -0700 (PDT) To: Yuanhan Liu , Panu Matilainen References: <571DDDD8.6000000@igel.co.jp> <571DE345.4000609@redhat.com> <20160426034710.GD7832@yliu-dev.sh.intel.com> Cc: "dev@dpdk.org" , "Xie, Huawei" , Thomas Monjalon From: Tetsuya Mukawa Message-ID: <571EFEA1.5080006@igel.co.jp> Date: Tue, 26 Apr 2016 14:37:37 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160426034710.GD7832@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 05:37:41 -0000 On 2016/04/26 12:47, Yuanhan Liu wrote: > On Mon, Apr 25, 2016 at 12:28:37PM +0300, Panu Matilainen wrote: > > >>> Another way is applying a below patch. >>> --- a/drivers/net/vhost/Makefile >>> +++ b/drivers/net/vhost/Makefile >>> @@ -38,6 +38,7 @@ LIB = librte_pmd_vhost.a >>> >>> CFLAGS += -O3 >>> CFLAGS += $(WERROR_FLAGS) >>> +LDLIBS += -lrte_vhost >>> >>> EXPORT_MAP := rte_pmd_vhost_version.map >>> >>> This is same way to link libpcap to librte_pmd_pcap. >>> What do you think about adding it to vhost PMD? >> Yes, this is absolutely the right thing to do. >> >> Ultimately this should be done for all dependencies in all libraries, but >> missing dependencies are even more pronounced in plugins so the sooner this >> goes in, the better. >> >> Acked-by: Panu Matilainen > Panu, thanks for the input. > > Tetsuya, please submit a formal patch so that I can merge. > > --yliu Hi Yuanhan, Oh sorry, I forgot to add "--in-reply-to" while sending the patch, so you may miss it. Also the order of Acked-by and Signed-off-by was wrong in above patch. So I will send v2 soon. Thanks, Tetsuya