From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id 6B912298F for ; Tue, 26 Apr 2016 08:01:02 +0200 (CEST) Received: by mail-pf0-f169.google.com with SMTP id c189so2641581pfb.3 for ; Mon, 25 Apr 2016 23:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=grZVHolCfWugycxm6UrSZeF3+Oy/Mi/f7eDnGq87Tn8=; b=t3utKrvwgK5iQ0cc8wbfn+fJpOPTKf4/r1NCG2Sj46KtZH3S83lZ8earLG04cjsX/v DkNfZXH3flwQfe72i4bOOSqTPRbxxttlsejdN2tg1yARNZY6cI9gYM9NnnRBZSU1vNFI o640PNkxXYamus/3/bTF/o46y55wgdkt9XoOe5PqD1bPhM8UOUlop4Wu0bsqLrlrRr7s EKhrkzpxq2sm33vgxP46xajGzWo44aVkrkLWNwcKXca3C554nUb865ZSqvOVyr0terYD drF1hlienrWb/I9FA3tPAT/ZLIlE1cnq6/JZ/DVQ646vwQDVSGWpAxbMULnodH3eF+5g PVrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=grZVHolCfWugycxm6UrSZeF3+Oy/Mi/f7eDnGq87Tn8=; b=YvpJ8nsvIGBygs4SnIhoP89icZI3Qo/+ObG7XEBmr9PsIrT9XSxS486mqSrXMNZ969 WuGBgNbhXyv28uC75Q0vUwru6lZ6C5QBv5iq+aArbPRJ3pW1aHND24HBsky1YI5n2y13 kSmGcHkfQVp/V5ga6LYhcLKFAEgfQxM863T1AN/ChyX2/GullPqlYLMhq22TiLu4D81v 1bf/w5+bO5KGtnY2as0hCUx4BBX6EVILaDXgtmP6u3lY1Yh3nWGpiYHlXsl4cD38ZNZY DwyUK3SUhgWI47q7FQ1pkrsIOskd3D97Z/OdogRkELeVMETjBptlebH1B6ahKO7SUtuq FJOA== X-Gm-Message-State: AOPr4FWfKfOlNa3ZB062P5vR9IMBd7ZoDNCcqUAHa5/YSIOzXlxcuDqpLyalFQCKdaSDgA== X-Received: by 10.98.34.141 with SMTP id p13mr1052795pfj.156.1461650461803; Mon, 25 Apr 2016 23:01:01 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id z6sm1580901pfz.11.2016.04.25.23.00.59 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 25 Apr 2016 23:01:01 -0700 (PDT) To: Yuanhan Liu References: <571DDDD8.6000000@igel.co.jp> <571DE345.4000609@redhat.com> <20160426034710.GD7832@yliu-dev.sh.intel.com> <571EFEA1.5080006@igel.co.jp> <20160426054844.GF7832@yliu-dev.sh.intel.com> Cc: Panu Matilainen , "dev@dpdk.org" , "Xie, Huawei" , Thomas Monjalon From: Tetsuya Mukawa Message-ID: <571F0419.2060207@igel.co.jp> Date: Tue, 26 Apr 2016 15:00:57 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160426054844.GF7832@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] Link ibrte_vhost to librte_pmd_vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 06:01:02 -0000 On 2016/04/26 14:48, Yuanhan Liu wrote: > On Tue, Apr 26, 2016 at 02:37:37PM +0900, Tetsuya Mukawa wrote: >> On 2016/04/26 12:47, Yuanhan Liu wrote: >>> On Mon, Apr 25, 2016 at 12:28:37PM +0300, Panu Matilainen wrote: >>> > >>>>> Another way is applying a below patch. >>>>> --- a/drivers/net/vhost/Makefile >>>>> +++ b/drivers/net/vhost/Makefile >>>>> @@ -38,6 +38,7 @@ LIB = librte_pmd_vhost.a >>>>> >>>>> CFLAGS += -O3 >>>>> CFLAGS += $(WERROR_FLAGS) >>>>> +LDLIBS += -lrte_vhost >>>>> >>>>> EXPORT_MAP := rte_pmd_vhost_version.map >>>>> >>>>> This is same way to link libpcap to librte_pmd_pcap. >>>>> What do you think about adding it to vhost PMD? >>>> Yes, this is absolutely the right thing to do. >>>> >>>> Ultimately this should be done for all dependencies in all libraries, but >>>> missing dependencies are even more pronounced in plugins so the sooner this >>>> goes in, the better. >>>> >>>> Acked-by: Panu Matilainen >>> Panu, thanks for the input. >>> >>> Tetsuya, please submit a formal patch so that I can merge. >>> >>> --yliu >> Hi Yuanhan, >> >> Oh sorry, I forgot to add "--in-reply-to" while sending the patch, so >> you may miss it. >> Also the order of Acked-by and Signed-off-by was wrong in above patch. >> So I will send v2 soon. > No worry. I could fix them, and I don't think there is a very strict > rule for both of them :) BTW, FYI, I just found my linux.intel.com > seems to be broken (no idea why), thus I made late response. > > (well, I found you just send a v2; I will apply that tomorrow). > > --yliu Thank you so much! Tetsuya