From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <declan.doherty@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id A472A902
 for <dev@dpdk.org>; Tue, 26 Apr 2016 12:55:33 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 26 Apr 2016 03:55:32 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,536,1455004800"; d="scan'208";a="940387147"
Received: from dwdohert-dpdk.ir.intel.com ([163.33.210.69])
 by orsmga001.jf.intel.com with ESMTP; 26 Apr 2016 03:55:30 -0700
To: Eric Kinzie <ehkinzie@gmail.com>, dev@dpdk.org
References: <1460654624-2066-1-git-send-email-ehkinzie@gmail.com>
From: Declan Doherty <declan.doherty@intel.com>
Message-ID: <571F4849.5030509@intel.com>
Date: Tue, 26 Apr 2016 11:51:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <1460654624-2066-1-git-send-email-ehkinzie@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] bond: inherit maximum rx packet length
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Apr 2016 10:55:34 -0000

On 14/04/16 18:23, Eric Kinzie wrote:
>    Instead of a hard-coded maximum receive length, allow the bond interface
>    to inherit this limit from the first slave added.  This allows
>    an application that uses jumbo frames to pass realistic values to
>    rte_eth_dev_configure without causing an error.
>
> Signed-off-by: Eric Kinzie <ehkinzie@gmail.com>
> ---
...
>

Hey Eric, just one small thing, I think it probably makes sense to 
return the max rx pktlen for all slaves, so as we add each slave just 
check if that the slave being value is larger than the current value.

@@ -385,6 +389,10 @@ __eth_bond_slave_add_lock_free(uint8_t 
bonded_port_id, uint8_t slave_port_id)
                 internals->tx_offload_capa &= dev_info.tx_offload_capa;
                 internals->flow_type_rss_offloads &= 
dev_info.flow_type_rss_offloads;

+               /* If new slave's max rx packet size is larger than 
current value then override */
+               if (dev_info.max_rx_pktlen > internals->max_rx_pktlen)
+                       internals->max_rx_pktlen = dev_info.max_rx_pktlen;
+

Declan