From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com
 [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 8995D5585
 for <dev@dpdk.org>; Thu, 28 Apr 2016 16:52:59 +0200 (CEST)
Received: from [10.16.0.195] (unknown [10.16.0.195])
 by proxy.6wind.com (Postfix) with ESMTP id B627624E69;
 Thu, 28 Apr 2016 16:51:22 +0200 (CEST)
To: "Wiles, Keith" <keith.wiles@intel.com>,
 "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>
References: <1459510581-31392-1-git-send-email-piotrx.t.azarewicz@intel.com>
 <1459846078-2369-1-git-send-email-piotrx.t.azarewicz@intel.com>
 <30864A3D-C66D-41AB-A02D-32D0BF9BE95E@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
From: Olivier MATZ <olivier.matz@6wind.com>
Message-ID: <572223C0.5030104@6wind.com>
Date: Thu, 28 Apr 2016 16:52:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
In-Reply-To: <30864A3D-C66D-41AB-A02D-32D0BF9BE95E@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 1/1] cmdline: add any multi string mode to
 token string
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Apr 2016 14:52:59 -0000

Hi Keith,

On 04/15/2016 04:41 PM, Wiles, Keith wrote:
>> While parsing token string there may be several modes:
>> - fixed single string
>> - multi-choice single string
>> - any single string
>>
>> This patch add one more mode - any multi string.
>>
>> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
>
> Does this patch also require updates to the documentation?

I did a quick check and it seems we do not dive as far in the
command line documentation (guides/sample_app_ug/cmd_line.rst).

But I agree that a comment could be added above the definition
of TOKEN_STRING_MULTI that would explain what is the behavior
in that case.

Piotr, do you think this is something you can do?

Thanks,
Olivier