From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 9E3A4558B for ; Fri, 29 Apr 2016 14:25:19 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1aw7Vo-0001Oa-PF; Fri, 29 Apr 2016 14:27:13 +0200 To: "dev@dpdk.org" , "Zhang, Helin" Cc: "Ananyev, Konstantin" , John Daley From: Olivier Matz Message-ID: <572352A3.6030400@6wind.com> Date: Fri, 29 Apr 2016 14:25:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] removing mbuf error flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2016 12:25:19 -0000 Hi, In rte_mbuf.h, some rx flags are set to 0 since a long time since nearly 2 years. It means nobody use them. They were introduced by the following commit: http://dpdk.org/browse/dpdk/commit/?id=c22265f6 As far as I understand, these flags were introduced to let the application know that a received packet is invalid. The 2 drivers using them are i40e and enic. But as this flags are 0 today, it means that invalid packets are silently given to the application. My opinion is that invalid packets should not be given to the application and only a statistic counter should be incremented. No application check these flags today (in examples, or testpmd). I would like to remove these flags. Thoughs? Olivier