From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
david.marchand@6wind.com
Subject: Re: [dpdk-dev] Build failure on RHEL 7.4
Date: Wed, 11 Apr 2018 22:14:01 +0200 [thread overview]
Message-ID: <5728107.6b9GQzpIaH@xps> (raw)
In-Reply-To: <2544114.h6jezT9v71@xps>
11/04/2018 21:56, Thomas Monjalon:
> 11/04/2018 21:46, Pavan Nikhilesh:
> > On Wed, Apr 11, 2018 at 09:40:30PM +0200, Thomas Monjalon wrote:
> > > 11/04/2018 21:09, Andrew Rybchenko:
> > > > Hello,
> > > >
> > > > build fails on RHEL 7.4. I've not tried to dig it.
> > >
> > > Thanks for reporting.
> > >
> > > [...]
> > > > ‘FALLOC_FL_PUNCH_HOLE’ undeclared (first use in this function)
> > > [...]
> > > > ‘FALLOC_FL_KEEP_SIZE’ undeclared (first use in this function)
> > >
> > > These constants were defined in Linux 2.6.23 and 2.6.38.
> > >
> > > [...]
> > > > $ uname -r
> > > > 3.10.0-693.el7.x86_64
> > >
> > > It should be OK.
> > >
> > > I think we are just missing
> > > #include <linux/falloc.h>
> >
> > Currently there is a bug filed in glibc here for the exact same kernel version.
> > https://bugzilla.redhat.com/show_bug.cgi?id=1476120
>
> The man page says: "The FALLOC_FL_* flags are defined in glibc headers
> only since version 2.18."
>
> I guess we can workaround with a direct include.
Fixed and rebased
Tested by David, thanks
prev parent reply other threads:[~2018-04-11 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 19:09 Andrew Rybchenko
2018-04-11 19:40 ` Thomas Monjalon
2018-04-11 19:46 ` Pavan Nikhilesh
2018-04-11 19:56 ` Thomas Monjalon
2018-04-11 20:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5728107.6b9GQzpIaH@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).