From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C4BB81B7EA
 for <dev@dpdk.org>; Wed, 11 Apr 2018 22:14:05 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 1102A20DDC;
 Wed, 11 Apr 2018 16:14:04 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 11 Apr 2018 16:14:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=2QBXBNoz94lV2dgTRpwXaZxVIK
 sDUHrrnj6AaTSx1DE=; b=Rr0+GQOndKqYHWhTXSsw7xiW1B7Vkzf8yT6BtBzi+8
 55yoPtj1MAO5A+Yc1jqZAVseIVNelXCKyP9abqVkBpQLGXDIhEtwDvBYvPL+ngLx
 I2UjXrQfhxxjgJTEEydMYZzw9Qa3HCegbJq8HmrrzfSFMVhxRTBC8NL+7+RRSLyP
 I=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=2QBXBN
 oz94lV2dgTRpwXaZxVIKsDUHrrnj6AaTSx1DE=; b=CR9GN0+vqPxMx9oyQdqSxb
 c5oHmSad3NN//SJbhEDBLSsX1qh8tR0vJyjfpuyVBpK8wyixzb7D9q/GMNMdPhZg
 UV3AvYZRUHfAaWSK49NWlpRckB2sFh5Q7SrLxN4kcVxHCZ/d2QZSeiZRQy8JMUaY
 MnGjI71Z71YcY2HhGDNz7SbSt/8sm/pphqXQxfcUzwHF0qvd35F3fI2CuzmP4Pch
 szul5YlvdxL9c3KD1HlyQ9H+sdAooJHAOtzpHGA1UvGIoggRdzMomCgATG5Qig/1
 0B/68afqcYqvf9jr0UPX5mb6sZu4Zz2xAo5qyHODceJ1Jf8JK+SzgWuu0c5y6hHA
 ==
X-ME-Sender: <xms:i2zOWmPBfJduRk6_vEg9Bhp-6o3W6iyXtOErSxrdH2K0s8EMFZZ3Tg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 1A009E4122;
 Wed, 11 Apr 2018 16:14:03 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, david.marchand@6wind.com
Date: Wed, 11 Apr 2018 22:14:01 +0200
Message-ID: <5728107.6b9GQzpIaH@xps>
In-Reply-To: <2544114.h6jezT9v71@xps>
References: <cd189dd0-67b4-4431-b709-366009ed8e12@solarflare.com>
 <20180411194627.GA17965@ltp-pvn> <2544114.h6jezT9v71@xps>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] Build failure on RHEL 7.4
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Apr 2018 20:14:06 -0000

11/04/2018 21:56, Thomas Monjalon:
> 11/04/2018 21:46, Pavan Nikhilesh:
> > On Wed, Apr 11, 2018 at 09:40:30PM +0200, Thomas Monjalon wrote:
> > > 11/04/2018 21:09, Andrew Rybchenko:
> > > > Hello,
> > > >
> > > > build fails on RHEL 7.4. I've not tried to dig it.
> > >
> > > Thanks for reporting.
> > >
> > > [...]
> > > > =E2=80=98FALLOC_FL_PUNCH_HOLE=E2=80=99 undeclared (first use in thi=
s function)
> > > [...]
> > > > =E2=80=98FALLOC_FL_KEEP_SIZE=E2=80=99 undeclared (first use in this=
 function)
> > >
> > > These constants were defined in Linux 2.6.23 and 2.6.38.
> > >
> > > [...]
> > > > $ uname -r
> > > > 3.10.0-693.el7.x86_64
> > >
> > > It should be OK.
> > >
> > > I think we are just missing
> > > 	#include <linux/falloc.h>
> >=20
> > Currently there is a bug filed in glibc here for the exact same kernel =
version.
> > https://bugzilla.redhat.com/show_bug.cgi?id=3D1476120
>=20
> The man page says: "The FALLOC_FL_* flags are defined in glibc headers
> only since version 2.18."
>=20
> I guess we can workaround with a direct include.

=46ixed and rebased
Tested by David, thanks