From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 7D4B42904
 for <dev@dpdk.org>; Tue,  3 May 2016 15:24:32 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga101.jf.intel.com with ESMTP; 03 May 2016 06:24:24 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,572,1455004800"; d="scan'208";a="797739372"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.48])
 ([10.237.221.48])
 by orsmga003.jf.intel.com with ESMTP; 03 May 2016 06:24:23 -0700
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1461947665-1086-1-git-send-email-ferruh.yigit@intel.com>
 <2540046.4XauHpbFhJ@xps13>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <5728A686.5040004@intel.com>
Date: Tue, 3 May 2016 14:24:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <2540046.4XauHpbFhJ@xps13>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] mk: add rpath for applications
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 May 2016 13:24:32 -0000

On 5/2/2016 5:10 PM, Thomas Monjalon wrote:
> 2016-04-29 17:34, Ferruh Yigit:
>> Add default library output folder to the library search folder.
>>
>> This is useful for development environment, in production environment
>> DPDK libraries already should be in know locations.
> 
> Yes it is useful in dev environment, but can be risky or strange when
> packaged for production environment.
> Shouldn't we have a switch to avoid a development garbage in production?
> I suggest to use RTE_DEVEL_BUILD.
> 

Right, I will use RTE_DEVEL_BUILD

>> Patch removes requirement to set LD_LIBRARY_PATH variable when DPDK
>> compiled as shared library.
> 
> Yes, this patch could remove
> 	export LD_LIBRARY_PATH=$build/lib:$LD_LIBRARY_PATH
> in scripts/test-null.sh.
> 

Sure, I can update it.

> [...]
>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
>> +LDFLAGS += --rpath=$(RTE_SDK_BIN)/lib
>> +endif
> 
> Isn't it -rpath, with a single dash?
> 

It seems both are working, I will convert to single dash.

> As it is a variable setting, it should be added before the rules,
> just after LDLIBS settings.
> 

OK.
I will send an updated version.


Thanks for the review,
ferruh