From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B8BC547D0 for ; Thu, 5 May 2016 18:08:01 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 05 May 2016 09:08:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,582,1455004800"; d="scan'208";a="697312021" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.65]) ([10.237.220.65]) by FMSMGA003.fm.intel.com with ESMTP; 05 May 2016 09:08:00 -0700 To: Bruce Richardson , dev@dpdk.org References: <1462379876-21901-1-git-send-email-bruce.richardson@intel.com> <20160505125942.GA14228@bricha3-MOBL3> Cc: thomas.monjalon@6wind.com From: Ferruh Yigit Message-ID: <572B6FDE.4000209@intel.com> Date: Thu, 5 May 2016 17:07:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160505125942.GA14228@bricha3-MOBL3> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] eal: add missing include to debug header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 16:08:03 -0000 On 5/5/2016 1:59 PM, Bruce Richardson wrote: > On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote: >> The header file rte_debug.h makes use of the "unlikely" macro which >> means it should include the rte_branch_prediction.h header file. >> >> Fixes: 50705e8e3cdd ("eal: add assert macro for debug") >> >> Signed-off-by: Bruce Richardson >> --- >> lib/librte_eal/common/include/rte_debug.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h >> index 9260eda..cab6fb4 100644 >> --- a/lib/librte_eal/common/include/rte_debug.h >> +++ b/lib/librte_eal/common/include/rte_debug.h >> @@ -44,6 +44,7 @@ >> */ >> >> #include "rte_log.h" >> +#include "rte_branch_prediction.h" >> >> #ifdef __cplusplus >> extern "C" { > > Ping on this patch - any comments or concerns? > It's a fairly trivial fix that prevents issues with testing some other patches > on the mainline. > Tested on top of David Marchand's 12123-12139 patchset. Acked-by: Ferruh Yigit