From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 2FD439AB7
 for <dev@dpdk.org>; Tue, 10 May 2016 12:27:14 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 10 May 2016 03:27:03 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,604,1455004800"; d="scan'208";a="949859210"
Received: from rhorton-mobl.ger.corp.intel.com (HELO [163.33.230.12])
 ([163.33.230.12])
 by orsmga001.jf.intel.com with ESMTP; 10 May 2016 03:27:02 -0700
Message-ID: <5731B775.3080302@intel.com>
Date: Tue, 10 May 2016 11:27:01 +0100
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Rasesh Mody <rasesh.mody@qlogic.com>, 
 Bruce Richardson <bruce.richardson@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, 
 Dept-Eng DPDK Dev <Dept-EngDPDKDev@qlogic.com>,
 Harish Patil <harish.patil@qlogic.com>
References: <1462340302-25683-1-git-send-email-rasesh.mody@qlogic.com>
 <1462340302-25683-2-git-send-email-rasesh.mody@qlogic.com>
 <20160506144709.GC8880@bricha3-MOBL3>
 <BY1PR11MB015127ADE8DA87944802CFE6857E0@BY1PR11MB0151.namprd11.prod.outlook.com>
In-Reply-To: <BY1PR11MB015127ADE8DA87944802CFE6857E0@BY1PR11MB0151.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 May 2016 10:27:14 -0000


On 07/05/2016 01:14, Rasesh Mody wrote:
[..]
>>> Enhance the stats_get() routine to display drop counters under imissed
>>> counter.
>>> Added extended stats get support to provide additional info.
>>> Encorporated review comment to rename some of the stats.
[..]
> We shall split this patch into an enhancement and a bug fix.

Keep in mind that the xstats API is changing so that stats_get() no 
longer includes strings:

http://thread.gmane.org/gmane.comp.networking.dpdk.devel/37079
http://thread.gmane.org/gmane.comp.networking.dpdk.devel/37571

..Remy