From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88F60A04BC; Tue, 29 Sep 2020 18:31:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A991C1BC27; Tue, 29 Sep 2020 18:31:55 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 013DB1B6E7 for ; Tue, 29 Sep 2020 18:31:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B8BB040C; Tue, 29 Sep 2020 12:31:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 29 Sep 2020 12:31:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= yY3odxhVDTaQu7t/4nwoq7TtMI1CzD1MPSBC5aPdIKQ=; b=DRqJT2aA0fX27gZj EFFfJi32F3BlZUy8bRbfNb3/HttFORscMSXlnoSyB03qTHNOpCe+GxqYqhAWMOkI cWmojsKs6vk0AwowcwlYM9Ji4TWdpdgQRwMEUhkMDfdIUWrRVxnpVkmTQB3VA2UD XJg02U4STAfhpZOa9Lu3sXcvUdGIn/KIdOuxL3+V59UGYOZnPyppSURrRaP8sj89 O4vaAxqwMPg6wzPkafiDNHV/+teOlacMJl8tl2XvDYB+aDaJCdA7FxD4Ruhy95Cf XjO6Xn8aDnU2M8eNI4VRexjIBp8OEF7kHjbTafo02zFN82XNnF0sw2lybBdY2or9 uR//nA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=yY3odxhVDTaQu7t/4nwoq7TtMI1CzD1MPSBC5aPdI KQ=; b=tvsxDKsuBML+CVIDgipm2nRQb/GYgwrhym7TpSHZ8PWgyw0t7TLv9Ofjf Ey56wRIJl6NLsSR0w3+U5eA2Hk3iwYLA1c3Cnt388hfMW6Kd8gxHM+ADT3CjVo6J UwEE/qXKBnfBoPAECwESAO9rI6QqEwsoE0JHwpNiyRNvlE/3kOTf069eItxE/XZ6 Ve/q3Z8WF67p38BxNgvgA58O76mxmXmx/5ktWKgjlcuQQfilof4+clCOEiyWFccF CCb2ExOlVBKE4yWCR+nfw6ON4Wtuc0fb9lDnKIBVCRQlmINq5eTBHXMhLnB1PGeG VGOqqT/3ut+QKsJ+8jifPqlh4faRA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdekgddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepteduueejkedtheeufedtleeihefgffdvudetudfhteekgeevkeeg kedtfffhgeetnecuffhomhgrihhnpeguohighihgvghnrdhnlhenucfkphepjeejrddufe egrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9ACFE3280063; Tue, 29 Sep 2020 12:31:50 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Tue, 29 Sep 2020 18:31:49 +0200 Message-ID: <5733395.4N6NXWAPF1@thomas> In-Reply-To: <20200929162325.GC966@bricha3-MOBL.ger.corp.intel.com> References: <20200929153413.280581-1-bruce.richardson@intel.com> <3530692.ZXM58GVc4I@thomas> <20200929162325.GC966@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/4] doc/api: hide verbose doxygen standard output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/09/2020 18:23, Bruce Richardson: > On Tue, Sep 29, 2020 at 05:55:44PM +0200, Thomas Monjalon wrote: > > > The standard output of doxygen is very verbose, and since ninja mixes > > > stdout and stderr together it makes it difficult to see any warnings from > > > the doxygen run. Therefore, we can just log the standard output to file, > > > and only output the stderr to make warnings clear. > > [...] > > > -doxygen "${DOXYCONF}" | tee doxygen.out > > > +doxygen "${DOXYCONF}" > doxygen.out > > > > ninja is printing extra lines: > > ninja: Entering directory `build' > > [0/1] Running external command doc > > Building docs: Doxygen_API HTML_Guides > > > > It makes hard to detect whether all run fine or not. > > Can we remove these extra lines with a ninja option? > > Can we return an error if there are some errors in doxygen? > > > If doxygen fails, then the whole build should fail - though to be honest > that is hard to test since most invalid changes I've tried making end up > just as warnings. The wrapper script for doxygen has "-e" flag so it should > fail if any part of it does, i.e. doxygen, and ninja always returns error > if any subtask fails. > > There is also the WARN_AS_ERROR setting for doxygen which we can use if you > want to be stricter [1]. Once all warnings are fixed, I'd suggest setting > that based on the werror setting for the build as a whole. > > [1] https://www.doxygen.nl/manual/config.html#cfg_warn_as_error Yes good idea. Can we make WARN_AS_ERROR depending on the meson option -werror?