From: Olivier MATZ <olivier.matz@6wind.com>
To: "Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] test-pmd: Free of address-of expression
Date: Tue, 17 May 2016 10:16:23 +0200 [thread overview]
Message-ID: <573AD357.40602@6wind.com> (raw)
In-Reply-To: <158888A50F43E34AAE179517F56C97455A52C6@IRSMSX103.ger.corp.intel.com>
Hi,
On 05/17/2016 09:55 AM, Mrozowicz, SlawomirX wrote:
> Hi,
>
> Noticed is that in the file:
>
> app/test-pmd/mempool.c
>
> using of the function munmap() could cause a problem.
>
> Coverity static code analyzer provide error (CID 13184) in line 158:
>
> munmap frees incorrect pointer uv.
>
> I noticed information on the net:
>
> https://www.ibm.com/support/knowledgecenter/SSLTBW_2.1.0/com.ibm.zos.v2r1.bpxbd00/mumap.htm
>
> “If addr is not the address of a mapping established by a prior call to
> mmap(), the behavior is undefined”
>
> I have analyzed the code and I have done some test with gcc.
>
> It seems that it is possible to free subrange of the mapping memory.
>
> In the mempool.c code the address is calculated independently.
>
> Anyway in my opinion the address variable uv is calculated correctly.
>
> So we should classify this issue as a False Positive.
>
> Please accept the conclusion.
This file (app/test-pmd/mempool_anon.c) will be removed soon.
Please see http://dpdk.org/dev/patchwork/patch/12067/
So I think we can ignore this alert, as the new code does not
have the same issue.
Regards,
Olivier
prev parent reply other threads:[~2016-05-17 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 7:55 Mrozowicz, SlawomirX
2016-05-17 8:16 ` Olivier MATZ [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573AD357.40602@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=slawomirx.mrozowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).