From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 9560E5921
 for <dev@dpdk.org>; Thu,  9 Jul 2015 01:18:17 +0200 (CEST)
Received: by wifm2 with SMTP id m2so2685701wif.1
 for <dev@dpdk.org>; Wed, 08 Jul 2015 16:18:17 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=qRG62pcE8bl5oD0/GAVbRf9X4CzOPAc6MpXF4ANJq0g=;
 b=dQx4z7pGsoVPHtzKBSh8mBm643JmclqkzuzARI0DWecNayMMr/OrDE+mu0H3PuzmfJ
 t90Y012gCLowwNIOS03JMRc4DuokY0QjkvuIoOv7J+LkAO21tO930+qj5lrQmsDV/eda
 hM0FBr5VfqzwFd+PMhAzThGbdgJbwF2BbDSzsuicNiwcjHfwe+cmWDpNfL2qTCHHavIg
 740kMnzfiqN5w3dS+he8zBZWVFB2J1k+VxHDJtnDtDqmGgDED+L7oJnz0Lhhk+FgsaUR
 MJyRXiHu5q30ZX0TJvVrrZJqkw5fdAUMw5oA8EedzQS567cJet68/1Q9b+wl5qTkQqts
 ni1Q==
X-Gm-Message-State: ALoCoQlx8juJBKqTK4Gg2Rjp2aPtGrn1XPd97he96cQWugjFQ1PWhOM9vi1y0F/LKI9VWxJA0lDg
X-Received: by 10.194.79.98 with SMTP id i2mr23823555wjx.111.1436397497488;
 Wed, 08 Jul 2015 16:18:17 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id ym2sm5707721wjc.44.2015.07.08.16.18.15
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Jul 2015 16:18:16 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Date: Thu, 09 Jul 2015 01:17:11 +0200
Message-ID: <57456880.mAaSW7tfxi@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <2601191342CEEE43887BDE71AB97725836A08EFD@irsmsx105.ger.corp.intel.com>
References: <1433403216-7114-1-git-send-email-helin.zhang@intel.com>
 <1434094441-23906-1-git-send-email-helin.zhang@intel.com>
 <2601191342CEEE43887BDE71AB97725836A08EFD@irsmsx105.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 0/6] query hash key size in byte
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2015 23:18:17 -0000

> > As different hardware has different hash key sizes, querying it (in byte)
> > per port was asked by users. Otherwise there is no convenient way to know
> > the size of hash key which should be prepared.
> > 
> > v2 changes:
> > * Disabled the code changes by default, to avoid breaking ABI compatibility.
> > 
> > v3 changes:
> > * Moved the newly added element right after 'uint16_t reta_size', where it
> >   was a padding. So it will not break any ABI compatibility, and no need to
> >   disable the code changes by default.
> > 
> > Helin Zhang (6):
> >   ethdev: add an field for querying hash key size
> >   e1000: fill the hash key size
> >   fm10k: fill the hash key size
> >   i40e: fill the hash key size
> >   ixgbe: fill the hash key size
> >   app/testpmd: show the hash key size
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied, thanks

It is assumed that inserting a new field in a padding alignment won't break
the ABI.