From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
Cc: harish.patil@qlogic.com
Subject: Re: [dpdk-dev] [PATCH] qede: fix build issue in the cross-compiling mode
Date: Wed, 25 May 2016 18:01:47 +0100 [thread overview]
Message-ID: <5745DA7B.2000505@intel.com> (raw)
In-Reply-To: <1464169261-25455-1-git-send-email-jerin.jacob@caviumnetworks.com>
On 5/25/2016 10:41 AM, Jerin Jacob wrote:
> In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
> instead of just gcc
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> drivers/net/qede/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
> index c9b3b1c..10ced84 100644
> --- a/drivers/net/qede/Makefile
> +++ b/drivers/net/qede/Makefile
> @@ -47,7 +47,7 @@ endif
> endif
> endif
>
> -ifneq (,$(filter gcc gcc48,$(CC)))
> +ifneq (,$(filter %gcc %gcc48,$(CC)))
What about: ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
This saves adding gcc version or cross compilation related check.
> CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
> CFLAGS_BASE_DRIVER += -Wno-missing-declarations
> CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized
>
next prev parent reply other threads:[~2016-05-25 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 9:41 Jerin Jacob
2016-05-25 17:01 ` Ferruh Yigit [this message]
2016-05-25 17:27 ` Thomas Monjalon
2016-05-26 6:12 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
2016-05-26 6:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5745DA7B.2000505@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).