From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id AFFEA2A66
 for <dev@dpdk.org>; Wed, 25 May 2016 19:02:55 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP; 25 May 2016 10:01:48 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,364,1459839600"; d="scan'208";a="962223224"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.49])
 ([10.237.220.49])
 by orsmga001.jf.intel.com with ESMTP; 25 May 2016 10:01:47 -0700
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
References: <1464169261-25455-1-git-send-email-jerin.jacob@caviumnetworks.com>
Cc: harish.patil@qlogic.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <5745DA7B.2000505@intel.com>
Date: Wed, 25 May 2016 18:01:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1464169261-25455-1-git-send-email-jerin.jacob@caviumnetworks.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] qede: fix build issue in the cross-compiling
 mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2016 17:02:56 -0000

On 5/25/2016 10:41 AM, Jerin Jacob wrote:
> In cross-compiling mode CC can be aarch64-*-linux-gnu-gcc
> instead of just gcc
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  drivers/net/qede/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
> index c9b3b1c..10ced84 100644
> --- a/drivers/net/qede/Makefile
> +++ b/drivers/net/qede/Makefile
> @@ -47,7 +47,7 @@ endif
>  endif
>  endif
>  
> -ifneq (,$(filter gcc gcc48,$(CC)))
> +ifneq (,$(filter %gcc %gcc48,$(CC)))

What about: ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
This saves adding gcc version or cross compilation related check.

>  CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable
>  CFLAGS_BASE_DRIVER += -Wno-missing-declarations
>  CFLAGS_BASE_DRIVER += -Wno-maybe-uninitialized
>