From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com [209.85.215.53]) by dpdk.org (Postfix) with ESMTP id 885D4678E for ; Mon, 30 May 2016 11:00:29 +0200 (CEST) Received: by mail-lf0-f53.google.com with SMTP id k98so69567202lfi.1 for ; Mon, 30 May 2016 02:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=qmkP1hjqH/J8NG6rw/yRwPzYvLMOlHuUiAKUXrCp2pc=; b=06p7N+fyUgf4wNQVWjxbgfwTeFzsFVatCvZuX+c0M1h7LkqqVZuZreEGDE1wDOQSWb hmdtrTWY3kq25SMO3kYtXr1SjrFVqvyAxAxVnYcdPwlShjeODAfhgB2lCdkDaGdWdluQ 2/2u/LexvHp92PF+99E3t2kNnF+Os+TVVz1OIOp/mkmJU7I9NwpChZK4cVwjvAdgfaCW YAT9/wvMnaW6CUVVQNJZ+pUxyp2CrB1wJnqI+jQN53tCJ6hZumZ3/Jhd3H8KBQzKDRwx Uywut++YWzOkLm/SCGm/nqe5hcxlyZKDZR9KjT/lx0RVDHTFuTe6ZvCKa1KTAr2IigTJ 2Ung== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=qmkP1hjqH/J8NG6rw/yRwPzYvLMOlHuUiAKUXrCp2pc=; b=OKgSOe8G1uq0F02F8htSbBWsgqHSibiVs82Lfodr4WAEw6cbbjcm2xB7mY356tAX08 h2iRUZRSvAMBLrdBB9o8kkdC8I2eDXbaOzfDS8SN2Xp7xYHTwQyElgQ7oOKzifXlGV2y EaHdAdI0OIeoXkyznv+dGfaF1JdX6qjj5H2ZybJk9bwob/SSI9DV1z6CWvzWU8772Reh 45PAZgm2zIiZciDuyiOHouckn/ds2u40KRIxm+nWXQ992xS+i2A8DZw9JCtp2X0qcvQr 8+bbyAzf5gCssHkImAW1D8/eelq33sD6Ql/d2jtWb4EBzmLnqVey4V2aFHiF/uk2eFw0 bpCg== X-Gm-Message-State: ALyK8tIfbiyy1aBIx00EGhzYzDts5bav113lPspo52p6AhWbjyaAxcBSfA6kkHBh8TPfAw== X-Received: by 10.25.8.3 with SMTP id 3mr8058558lfi.200.1464598829125; Mon, 30 May 2016 02:00:29 -0700 (PDT) Received: from [10.0.2.212] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.googlemail.com with ESMTPSA id h4sm162457ljh.29.2016.05.30.02.00.27 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 30 May 2016 02:00:28 -0700 (PDT) To: Remy Horton References: <1462963714-21022-1-git-send-email-zr@semihalf.com> <1464158214-24733-1-git-send-email-zr@semihalf.com> <5745A544.8050505@intel.com> Cc: thomas.monjalon@6wind.com, dev@dpdk.org From: Zyta Szpak Message-ID: <574C012B.60302@semihalf.com> Date: Mon, 30 May 2016 11:00:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <5745A544.8050505@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add callback to get register size in bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2016 09:00:29 -0000 Hi, It is the standard DPDK return value -ENOTSUP when the function is not supported by Ethernet device. I think it is safer to keep it this way rather than default implicitly to sizeof(uint32_t) and more generic. Regards, Zyta On 25.05.2016 15:14, Remy Horton wrote: > 'noon, > > Was expecting rte_eth_dev_get_reg_width() itself to default to > sizeof(uint32_t) rather than -ENOTSUP, but that is purely personal > taste which others might disagree with. You'll also need a > documentation update & Fixes: line. > > > On 25/05/2016 07:36, zr@semihalf.com wrote: >> From: Zyta Szpak > [..] >> Signed-off-by: Zyta Szpak > > Acked-by: Remy Horton