From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id C37185A8F for ; Tue, 31 May 2016 09:39:23 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id z87so95516543wmh.0 for ; Tue, 31 May 2016 00:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=c1QiQFrZ6mMrSH6QCDQiqTvbWidf9cgR6aF5n7iXTG0=; b=pZsSLFlbqRhWSnXKs86ocq0ef1Ibic4/R1xaCT4aaFWtv6SqBztSUZc8AzQLFvLK3O /ZLd3a7nAUVecN/z3d9wxj+/vJY84Ur0Fdk2sPxJo1HG51Iv+HuKU1JkbnJ6VNRopX5Q MUtzizOntoHXwaHSyAi0989ZNusMVwpL3/KpVzOXGggamYvhWeimFLALutVmoaeuhrj8 zFmiXezSv5rVzqa8Bnu8EUMWE9VIN77kUVUSpPAOSTqOaX+dECC5HEIDfccO/wRvdtVM oaSvZSLoI0jfKu9TNVOmjiiqBHO3UrTjyPV0b+er3Ayw8NnXC7R80BnhE5VJFI/yPt84 zQMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=c1QiQFrZ6mMrSH6QCDQiqTvbWidf9cgR6aF5n7iXTG0=; b=lZL+tfd3tvJjtL1wocD7wVzYzjkiWrJpN8k19PNMYonS2Nt6SxxP3h6k14DjsxaLlR f1JsA4IHdEzh4e+lsKGk/2wW/5q+HhEdnT9UqhyVfJjm6SiQRM2VRjtDf3Z+nCXyYTWB 4cqGANHFFRmbbiBCV9VXLMz01Pj6YTYRzt6PM3532R3NyOND3MKcI2ag7afRq+PGOnHi corMGhAkl2W5MqvgWHVEbWk9EmjoCB6cMecUj9HkFZ5xvg6qXYC0fqZ0pqDIkwGNLogl OYYz+e1Qofu33Xee8E/hVx9mHOFs4ovcJ+JIsBnI8/dgQmifEAvO6klVN7KDhJeNU0bB epHg== X-Gm-Message-State: ALyK8tItdh41g6CleaZ5IqHSSeiCbt+0HroYSL7CPXQsqpTBuGfjGAfbPgDUFBb2xwe2glLC X-Received: by 10.194.77.140 with SMTP id s12mr30533928wjw.24.1464680363521; Tue, 31 May 2016 00:39:23 -0700 (PDT) Received: from [137.194.57.102] (eduroam-1-102.enst.fr. [137.194.57.102]) by smtp.gmail.com with ESMTPSA id c4sm38504476wjm.24.2016.05.31.00.39.22 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 31 May 2016 00:39:22 -0700 (PDT) To: Thomas Monjalon References: <1464609857-30162-1-git-send-email-olivier.matz@6wind.com> <2644423.ubxL6r272Z@xps13> Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com From: Olivier MATZ Message-ID: <574D3FA2.10301@6wind.com> Date: Tue, 31 May 2016 09:39:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <2644423.ubxL6r272Z@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: log mbuf pool creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2016 07:39:23 -0000 Hi Thomas, On 05/30/2016 09:44 PM, Thomas Monjalon wrote: > 2016-05-30 14:04, Olivier Matz: >> Enhance the logs related to mbuf pool creation. Display an info level >> log when creating the mbuf, and display the error as a string on failure. >> >> After the patch, we have: >> >> [...] >> EAL: probe driver: 8086:10fb rte_ixgbe_pmd >> USER1: create a new mbuf pool : n=331456, \ >> size=2176, socket=0 >> EAL: Error - exiting with code: 1 >> Cause: Creation of mbuf pool for socket 0 failed: Cannot allocate \ >> memory > > Yes printing the error reason is a good improvement. > But why the previous line is at INFO level? It looks to be a debug. > Using INFO instead of DEBUG was done on purpose. I think the mbuf pool parameters is a valuable information for the user running testpmd, especially to ensure it's compatible with best performance. If you really think it should be DEBUG, I'll submit a v2. Regards, Olivier