Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add callback to get register size in bytes

[Zyta Szpak <zr@semihalf.com>]

On 30.05.2016 12:58, Panu Matilainen wrote:
> On 05/30/2016 12:39 PM, zr@semihalf.com wrote:
>> From: Zyta Szpak <zr@semihalf.com>
>>
>> Version 2 of fixing the fixed register width assumption.
>> rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks
>> do not provide register size to the app in any way. It is
>> needed to allocate proper number of bytes before retrieving
>> registers content with rte_eth_dev_get_reg.
>>
>> Signed-off-by: Zyta Szpak <zr@semihalf.com>
> [...]
>> diff --git a/lib/librte_ether/rte_ether_version.map 
>> b/lib/librte_ether/rte_ether_version.map
>> index 214ecc7..288bc63 100644
>> --- a/lib/librte_ether/rte_ether_version.map
>> +++ b/lib/librte_ether/rte_ether_version.map
>> @@ -130,5 +130,6 @@ DPDK_16.04 {
>>      rte_eth_tx_buffer_drop_callback;
>>      rte_eth_tx_buffer_init;
>>      rte_eth_tx_buffer_set_err_callback;
>> +    rte_eth_dev_get_reg_width;
>>
>>  } DPDK_2.2;
>
> This symbol did not exist in DPDK 16.04 so it must not be added there. 
> Add a new section for 16.07 which inherits from DPDK_16.04.
>
>     - Panu -
>
Right.