From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) by dpdk.org (Postfix) with ESMTP id 666182C7A for ; Tue, 31 May 2016 17:08:40 +0200 (CEST) Received: by mail-lf0-f43.google.com with SMTP id w16so80462773lfd.2 for ; Tue, 31 May 2016 08:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=aJYvlazHMi1qMRBFZ19EhLH2yGAf2jl1QZx9bC1RNYA=; b=rFKSaMA7D9/LG01pmIyJ1Zrsm6K212IWrvBVcxUBhcUqN0LPzvLiHTInjHzrmhgK5Z axP9a+UG8XVP1z8XfZQEBirkvbOCFdHUWULJwGovCTUFchxZ/Io+aDgyvATz9qxTfE4L SYR17xEp81VTjgRDD4FDoJjBwgWEGyWjL63RlNKE0tBkjPFWHRCf8OiB6xwwSNWxdp18 Qm+5qubJFnYqzi2G5uWWLEnOwJ3WgqRM59ew91W6nMHTaZWbE7fq8ysdW409wOgzdMMj 7jFnrVwTjVRWIPeAwdOsFX4LndT76Lxg3Yf3nQWybqipx/T20LeIv0NE6/e8RZiqDiom EwhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=aJYvlazHMi1qMRBFZ19EhLH2yGAf2jl1QZx9bC1RNYA=; b=jOaik1sXgv+5F1zDq5sqsBHj7HHN2dsdIYgpfbnulPLFEsVawjML9y08uEvfhNKen+ cs6KgWBhLOXP44ONnVwcVcZvkWv4p2hR429jlqEkP+pC5esGwvrgov/gQxe4zBZNhBdD hvlS4Nwmh7qdQL7wQfjU7jyNU+9Amez/sMvWIdGBMXKgrTwVcOY9WratZxtc0bDBcCzb ArkN4cgab4OtBi2GSZ80CSKGpjgs2j1RDym738XZCx8RSCz/hQmKGwPR5vKruyizcZ7G MIcpPHzk2zRy/R7Yo5yBjxHDHkMDKCvvGQXLutxWWp22o8pbwY6r2p1MkBbl5qQ31SAI 6t/w== X-Gm-Message-State: ALyK8tIjiXasoewcqM7G0+i9qDsUEmhdy378/trBP92VDqNFBwr6y0oYa5aVl3Xe884Icg== X-Received: by 10.25.196.146 with SMTP id u140mr9973299lff.164.1464707320055; Tue, 31 May 2016 08:08:40 -0700 (PDT) Received: from [10.0.2.212] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.googlemail.com with ESMTPSA id o75sm5465242lfi.9.2016.05.31.08.08.38 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 31 May 2016 08:08:39 -0700 (PDT) To: Panu Matilainen References: <1464601185-7330-1-git-send-email-zr@semihalf.com> <89305686-998b-9f36-d2c2-dc6ec123c5c5@redhat.com> Cc: dev@dpdk.org From: Zyta Szpak Message-ID: <574DA8F7.7020205@semihalf.com> Date: Tue, 31 May 2016 17:08:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <89305686-998b-9f36-d2c2-dc6ec123c5c5@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add callback to get register size in bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2016 15:08:40 -0000 On 30.05.2016 12:58, Panu Matilainen wrote: > On 05/30/2016 12:39 PM, zr@semihalf.com wrote: >> From: Zyta Szpak >> >> Version 2 of fixing the fixed register width assumption. >> rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks >> do not provide register size to the app in any way. It is >> needed to allocate proper number of bytes before retrieving >> registers content with rte_eth_dev_get_reg. >> >> Signed-off-by: Zyta Szpak > [...] >> diff --git a/lib/librte_ether/rte_ether_version.map >> b/lib/librte_ether/rte_ether_version.map >> index 214ecc7..288bc63 100644 >> --- a/lib/librte_ether/rte_ether_version.map >> +++ b/lib/librte_ether/rte_ether_version.map >> @@ -130,5 +130,6 @@ DPDK_16.04 { >> rte_eth_tx_buffer_drop_callback; >> rte_eth_tx_buffer_init; >> rte_eth_tx_buffer_set_err_callback; >> + rte_eth_dev_get_reg_width; >> >> } DPDK_2.2; > > This symbol did not exist in DPDK 16.04 so it must not be added there. > Add a new section for 16.07 which inherits from DPDK_16.04. > > - Panu - > Right.