From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <olivier.matz@6wind.com> Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id DBEA8379B for <dev@dpdk.org>; Tue, 31 May 2016 21:12:45 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id s131so24155206wme.0 for <dev@dpdk.org>; Tue, 31 May 2016 12:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=SKVx826NNRY7Nc95V49GmRsNG+yZNrLx3hnqf7EXXyA=; b=k1PoyzKFnIUvsJ8xu6uxzlfNqk51ZpxtT7Zn9DlCCVM8ULzNbs6mQyZ51+3CmeTreF pPjgFplGP/d/lahx2VpQ192VJCO7si+Whf3xz/Px2nbQMchsYmxq9ze5n0FmLeNmjium x3z8mxZAW9QQ64kFvcEo6xIWTw9aWYBhT0yjFDzT1bhTBGl67juw8Rr11l41FFLcm3Ss HOpYMu5P+pwFfSFTkxyw34MZDiQs4f2XcxcYJOeF/bdIv4XzaCvykqotnnpfNuDHpKZk cx17G/K2GO224NivP1CIXj4AVOwtnb/WE3DbQiUsLI84/OpV3kTdJJiXiGbtPuYZ628s XKiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=SKVx826NNRY7Nc95V49GmRsNG+yZNrLx3hnqf7EXXyA=; b=M3wmt4/VeahMc8GCB2D4HSGK4SdQPWHnxHr4luJLzNtK2PoZhuZNQekt9qB21WNJMU VDVUof79tOOn01ZbfeHmkscpi+BHnYiq+CESMJTDITsFQjXIC6ija+VX7gvW1hxdSsYP ViBLeCFFK3MVA0G1wz9S1z7Qn+Qg4ZG41jouBlC8mGMXEIGDxQupRm6CVLsGM8oUe5LL /1YKS60LK/hAxnyyxWDeLn41TNhH42sOgmZ88JhJOKMBic9mHqytoKfI7MKt4zjR+MTG F2ImFObz9F7KlQoNMz49vjU8vz00dmT1q4b4QbVqafZHKcY6/1BmZ0kwDj5/HKDKIvls JwsQ== X-Gm-Message-State: ALyK8tKgH85NnK6BoC29mZbuU8TLoSfIZDrv4oOvGGVe+mI/FuWkmzcF2oqYPINhkYEOOSUI X-Received: by 10.28.9.139 with SMTP id 133mr4812301wmj.93.1464721965734; Tue, 31 May 2016 12:12:45 -0700 (PDT) Received: from [192.168.0.16] (85-171-34-230.rev.numericable.fr. [85.171.34.230]) by smtp.gmail.com with ESMTPSA id k62sm30790226wmb.7.2016.05.31.12.12.44 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 31 May 2016 12:12:45 -0700 (PDT) To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org References: <1464609406-23152-1-git-send-email-olivier.matz@6wind.com> <574C6123.5090005@intel.com> <574C68A1.2090408@6wind.com> <574C6E71.3090601@intel.com> <574D933C.2080507@intel.com> Cc: thomas.monjalon@6wind.com, helin.zhang@intel.com From: Olivier MATZ <olivier.matz@6wind.com> Message-ID: <574DE22B.1010209@6wind.com> Date: Tue, 31 May 2016 21:12:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <574D933C.2080507@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] kni: fix use of undefined comma variable in makefile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 31 May 2016 19:12:46 -0000 Hi Ferruh, On 05/31/2016 03:35 PM, Ferruh Yigit wrote: > Error is related to the kernel version, in second call "comma" > definition comes from kernel makefiles. > > Following commit causes comma to be defined: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=371fdc77af44f4cb32475fd499e1d912ccc30890 > > So this is valid issue for old kernels, and using "," directly looks OK. > >> Signed-off-by: Olivier Matz <olivier.matz@6wind.com> > Acked-by Ferruh Yigit <ferruh.yigit@intel.com> Thanks for investigating the issue! Olivier