* [dpdk-dev] [PATCH] net/ring: add missing newlines in logs
@ 2017-07-06 15:47 Thomas Monjalon
2017-07-18 8:08 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Monjalon @ 2017-07-06 15:47 UTC (permalink / raw)
To: bruce.richardson; +Cc: dev
Some logs are missing the newline character \n.
The logs using only line can be checked with this command:
git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/
Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix linking")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/net/ring/rte_eth_ring.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 820a41104..6ac96a6a2 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -494,7 +494,7 @@ static int parse_kvlist (const char *key __rte_unused, const char *value, void *
node = strchr(name, ':');
if (!node) {
- RTE_LOG(WARNING, PMD, "could not parse node value from %s", name);
+ RTE_LOG(WARNING, PMD, "could not parse node value from %s\n", name);
goto out;
}
@@ -503,7 +503,7 @@ static int parse_kvlist (const char *key __rte_unused, const char *value, void *
action = strchr(node, ':');
if (!action) {
- RTE_LOG(WARNING, PMD, "could not action value from %s", node);
+ RTE_LOG(WARNING, PMD, "could not parse action value from %s\n", node);
goto out;
}
--
2.13.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ring: add missing newlines in logs
2017-07-06 15:47 [dpdk-dev] [PATCH] net/ring: add missing newlines in logs Thomas Monjalon
@ 2017-07-18 8:08 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-07-18 8:08 UTC (permalink / raw)
To: Thomas Monjalon, bruce.richardson; +Cc: dev
On 7/6/2017 4:47 PM, Thomas Monjalon wrote:
> Some logs are missing the newline character \n.
>
> The logs using only line can be checked with this command:
> git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/
>
> Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix linking")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-18 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-06 15:47 [dpdk-dev] [PATCH] net/ring: add missing newlines in logs Thomas Monjalon
2017-07-18 8:08 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).