From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 55B115A57 for ; Fri, 3 Jun 2016 14:28:48 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id a20so104254720wma.1 for ; Fri, 03 Jun 2016 05:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=/wA6nPesGo9SwGghh8paWubIUHtAXfWjzf9QJxyyTRM=; b=jXU/vcKX1jfC1KeUw82pr30UPO3KdFMLIecUIm0+IrZ5v91tdosFdhykulAUzK/p2F 4iDCyy8YafTMHF0+4vqrW/SzXrAa7q/MrJAnljIy86USdBqGyqwwz2t8oyQmD9uCWJ1t 0jCkTDT1Wf3Q71MwHmTkCjHoZ1kqbXyMNjdE5wwk7i3h5l3BeNJze7TOqrHRbBr4wzCt nd24ZZi1TuVQV/JXG5al1XutFacM7mXsG0V0W0y4XLHH4fsam9QtKJ0IWoXuAAooTbBk M9LwWZR5czxDf8i0TcPbiotOmnqHqr4KkrmsA5vDjxl1FmNANYVP3Ux8K11uU542LEuK F8Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=/wA6nPesGo9SwGghh8paWubIUHtAXfWjzf9QJxyyTRM=; b=DKbWfmx/OQ9Cm0jt96JiEHjb963l/sllYw4RWOys3EQ6W4yhXpLEHaOC5xGMP2tv6s luJAmQDxaeXxiGukFH0sbTgGqy0W0B26LK38E2iwjLU4+1rtded+K0az1AOgRGJBibg0 jGt+oiD6CDYFMc9ZOAb9YRzIjKM85yeLriCN1pD+S4i8Di2kQwjHma0x+6XyZx/KtUxB y519obcJ7cQwypt6Sq3mkLAlT/q5oqHQC9z+4jLo4b2ntIFYWHssg7MSKkpceQFQz/vP AsO0/N8OXSRH3KFvAOv95XTnQ8mVWYDs8ENxTsm4vvWsgpNOxkr7ccdNno+kzd3+nqgm hAcg== X-Gm-Message-State: ALyK8tLPlC7xi8QHMuZUEZhBKOdj7DzCIu1dyZI6ZvHuhbDMS0BcgHc39+heVEGzRxKqIMsA X-Received: by 10.194.201.162 with SMTP id kb2mr3587879wjc.55.1464956928114; Fri, 03 Jun 2016 05:28:48 -0700 (PDT) Received: from [192.168.0.11] (was59-1-82-226-113-214.fbx.proxad.net. [82.226.113.214]) by smtp.gmail.com with ESMTPSA id dd7sm5518400wjb.22.2016.06.03.05.28.46 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 03 Jun 2016 05:28:47 -0700 (PDT) To: David Hunt , dev@dpdk.org References: <1464797998-76690-1-git-send-email-david.hunt@intel.com> <1464874043-67467-1-git-send-email-david.hunt@intel.com> <1464874043-67467-3-git-send-email-david.hunt@intel.com> Cc: viktorin@rehivetech.com, jerin.jacob@caviumnetworks.com From: Olivier MATZ Message-ID: <575177FD.4020908@6wind.com> Date: Fri, 3 Jun 2016 14:28:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1464874043-67467-3-git-send-email-david.hunt@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 2/5] mempool: remove rte_ring from rte_mempool struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2016 12:28:48 -0000 On 06/02/2016 03:27 PM, David Hunt wrote: > Now that we're moving to an external mempoool handler, which > uses a void *pool_data as a pointer to the pool data, remove the > unneeded ring pointer from the mempool struct. > > Signed-off-by: David Hunt > --- > app/test/test_mempool_perf.c | 1 - > lib/librte_mempool/rte_mempool.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/app/test/test_mempool_perf.c b/app/test/test_mempool_perf.c > index cdc02a0..091c1df 100644 > --- a/app/test/test_mempool_perf.c > +++ b/app/test/test_mempool_perf.c > @@ -161,7 +161,6 @@ per_lcore_mempool_test(__attribute__((unused)) void *arg) > n_get_bulk); > if (unlikely(ret < 0)) { > rte_mempool_dump(stdout, mp); > - rte_ring_dump(stdout, mp->ring); > /* in this case, objects are lost... */ > return -1; > } > diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h > index a6b28b0..c33eeb8 100644 > --- a/lib/librte_mempool/rte_mempool.h > +++ b/lib/librte_mempool/rte_mempool.h > @@ -204,7 +204,6 @@ struct rte_mempool_memhdr { > */ > struct rte_mempool { > char name[RTE_MEMPOOL_NAMESIZE]; /**< Name of mempool. */ > - struct rte_ring *ring; /**< Ring to store objects. */ > union { > void *pool_data; /**< Ring or pool to store objects */ > uint64_t pool_id; /**< External mempool identifier */ > Sorry if I missed it in previous discussions, but I don't really see the point of having this in a separate commit, as the goal of the previous commit is to replace the ring by configurable ops. Moreover, after applying only the previous commit, the call to rte_ring_dump(stdout, mp->ring) would probably crash sine ring is NULL. I think this comment also applies to the next commit. Splitting between functionalities is good, but in this case I think the 3 commits are linked together, and it should not break compilation or tests to facilitate the git bisect. Regards, Olivier