From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C57AB5681 for <dev@dpdk.org>; Wed, 24 Oct 2018 15:19:42 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3DF172202E; Wed, 24 Oct 2018 09:19:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 24 Oct 2018 09:19:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=KXrGhmP834tz7R+/ZQQD586XiFjwjN2lYpq0wzHW3Is=; b=ReEHq4ZHE3C6 x12SS2v8mR/FIwbf6kjoFYmdeOXR0VVryfVrlWQBaH0jDoU1qzodZuH/1255S1Pr aoxTv7/GORNWUSXT4S749QEP72S1NIYlT/8rzIFM9thHOix7APp5MBRC3cPwrrr/ CBLBuz71YPHhxRcwX5ePCP/bokOXjmo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=KXrGhmP834tz7R+/ZQQD586XiFjwjN2lYpq0wzHW3 Is=; b=zYkq9BE2K6++5uAZxEue8AFZH+PzZ2fVdlAJ9Al2PNSddLuAHUj7/BnGO rQWYpN2Nftl78cDj0OCPNqCXHQ0/vzCpnG7FC8OcFXbDpWdFvfpvJ4T/+rfm9OMR UpKRVpXuwO/hfMJiSTxuss/a6N426q6d1BHSHgbHi3BocTbc1M7fcyrFXBS/9b9G fY0O36S846GEy8Ky8OND+yyHSUf8AMeO3HPOUTqZ8hO7KP0AxAXBld5NPdVYZy4O 4bA8ZNcY9Yb1yeYm2ORFw6gSI5+N2+BtI4qCM6CKAaCzdW6eKHCWJYnFhSbYrlTU lcwbdh5tbmSwCjU/n+DXw4xylYm4w== X-ME-Sender: <xms:bXHQW0INItsWr27clA_dqnEPiglLnExnfA9PwiwjQVBUrAwDOnpoXg> X-ME-Proxy: <xmx:bXHQW1mTmqNj8vX_EKUCQDh9kbisRr0FYkVOS6XUHibMgygfDG1Bcg> <xmx:bXHQW7CxJH0iM12pi3S8JRquQLiaLProx4IQuwlBta_1YGWyZ4ZLYg> <xmx:bXHQWwTmZTcfgLdg-5-yN0h07BmPgBEk6T98tY-M0RT04q9D232b9g> <xmx:bXHQW2IQGKyPog0BNpOeK96POCrazVdg0E8nk9jL5ky4bW7jgtpqlg> <xmx:bXHQW4FLhpwQjIAAhBzLdQcPhJNGIj-YWwGWoUEC6JsKudzUntjAHw> <xmx:bnHQW2Dt1P1O5hTPVoVJSTYa11OZCdhxhvxma1pDtL7PyNYbZpc8bw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 16AA9102EA; Wed, 24 Oct 2018 09:19:41 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>, ophirmu@mellanox.com Date: Wed, 24 Oct 2018 15:19:45 +0200 Message-ID: <5755587.GAzGENloro@xps> In-Reply-To: <20181024131321.8409-1-thomas@monjalon.net> References: <20181024131321.8409-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix iterator default behaviour for representors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 24 Oct 2018 13:19:43 -0000 24/10/2018 15:13, Thomas Monjalon: > The iterator was matching all representors if it was not specified > in the devargs string. It was a wrong default behaviour. > > If there is no representor parameter in the devargs, the iterator > should not match any representor port. > > The implementation of the default behaviour would be simpler > if a "no match" handler is added to rte_kvargs_process(). > As it requires an API breakage, it will be reworked later. > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> It is fixing the commit "support representor id as iterator filter" which is in dpdk-next-net tree. I think we should not squash them. It is fine to have both patches separated with a clear explanation. When the first commit will be in mainline, we could add a Fixes: tag to this patch.