From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7935F95FE for ; Tue, 7 Jun 2016 11:52:28 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 07 Jun 2016 02:52:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,432,1459839600"; d="scan'208";a="823210266" Received: from rhorton-mobl.ger.corp.intel.com (HELO [163.33.228.201]) ([163.33.228.201]) by orsmga003.jf.intel.com with ESMTP; 07 Jun 2016 02:52:26 -0700 Message-ID: <57569959.5000407@intel.com> Date: Tue, 07 Jun 2016 10:52:25 +0100 From: Remy Horton Organization: Intel Shannon Limited User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: zr@semihalf.com, thomas.monjalon@6wind.com CC: dev@dpdk.org References: <1464767771-19159-1-git-send-email-zr@semihalf.com> <1464767771-19159-2-git-send-email-zr@semihalf.com> In-Reply-To: <1464767771-19159-2-git-send-email-zr@semihalf.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/2] examples/ethtool: get reg width to allocate memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 09:52:28 -0000 On 01/06/2016 08:56, zr@semihalf.com wrote: > From: Zyta Szpak > > Version 2 of fixing the fixed register width assumption. > Not every device uses 32-bit wide register. The app was allocating too > little space for 64-bit registers which resulted in memory corruption. > This commit resolves this by getting the size of register in bytes for > a specific device. If the device does not implement this function, it > fallsback to sizeof(uint32_t) > > Signed-off-by: Zyta Szpak Acked-by: Remy Horton