From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C1B6F9601 for ; Wed, 8 Jun 2016 13:16:39 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 08 Jun 2016 04:16:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,438,1459839600"; d="scan'208";a="997712136" Received: from rhorton-mobl.ger.corp.intel.com (HELO [163.33.230.72]) ([163.33.230.72]) by fmsmga002.fm.intel.com with ESMTP; 08 Jun 2016 04:16:37 -0700 Message-ID: <5757FE95.3090403@intel.com> Date: Wed, 08 Jun 2016 12:16:37 +0100 From: Remy Horton Organization: Intel Shannon Limited User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thomas Monjalon CC: dev@dpdk.org References: <1464605292-4599-1-git-send-email-remy.horton@intel.com> <1464605292-4599-2-git-send-email-remy.horton@intel.com> <2437213.nzTWdctYcm@xps13> In-Reply-To: <2437213.nzTWdctYcm@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 01/10] rte: change xstats to use integer ids X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 11:16:40 -0000 'noon, On 08/06/2016 10:37, Thomas Monjalon wrote: > 2016-05-30 11:48, Remy Horton: >> struct rte_eth_xstats { >> + /* FIXME: Remove name[] once remaining drivers converted */ >> char name[RTE_ETH_XSTATS_NAME_SIZE]; > > What is the plan? This field must be deprecated with an attribute. > We cannot have 2 different APIs depending of the driver. This is where it gets logistically tricky.. Since there's an API/ABI breakage notice in place on this, my own preference would be to have the entire patchset quashed into a single patch. Problem is that rte/app changes (patches 1 & 7-9) are normally applied via master whereas driver changes (patches 2-6) go in via dpdk-next-net - it is not clear to me how patches should be submitted for this case.. > What are the remaining drivers to convert? Opps, none. All relevant drivers are converted.. > This structure and the other one (rte_eth_xstats) are badly named. > There is only one stat in each. So they should not have the plural form. > rte_eth_xstat and rte_eth_xstat_name would be better. I kept rte_eth_xstats as it was the name already in use within DPDK. Will change the other. >> +int rte_eth_xstats_count(uint8_t port_id); > > This function is useless because we can have the count with > rte_eth_xstats_get(p, NULL, 0) > By the way it would be more consistent to have the same behaviour > in rte_eth_xstats_names(). Feedback I got with earlier patches was that a seperate count function was preferable to overloading the fetch function using *data==NULL - is the use of the latter specifically preferred? Other comments noted. ..Remy