From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 162459AC0
 for <dev@dpdk.org>; Wed,  8 Jun 2016 14:11:07 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga103.fm.intel.com with ESMTP; 08 Jun 2016 05:11:07 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,438,1459839600"; d="scan'208";a="983316486"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.53])
 ([10.237.221.53])
 by fmsmga001.fm.intel.com with ESMTP; 08 Jun 2016 05:11:05 -0700
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
References: <1464540424-12631-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1465317632-11471-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1465317632-11471-13-git-send-email-jerin.jacob@caviumnetworks.com>
Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com,
 Maciej Czekaj <maciej.czekaj@caviumnetworks.com>,
 Kamil Rytarowski <Kamil.Rytarowski@caviumnetworks.com>,
 Zyta Szpak <zyta.szpak@semihalf.com>,
 Slawomir Rosek <slawomir.rosek@semihalf.com>,
 Radoslaw Biernacki <rad@semihalf.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <57580B58.3090707@intel.com>
Date: Wed, 8 Jun 2016 13:11:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1465317632-11471-13-git-send-email-jerin.jacob@caviumnetworks.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 12/20] thunderx/nicvf: add single and
 multi segment tx functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2016 12:11:08 -0000

On 6/7/2016 5:40 PM, Jerin Jacob wrote:
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Signed-off-by: Maciej Czekaj <maciej.czekaj@caviumnetworks.com>
> Signed-off-by: Kamil Rytarowski <Kamil.Rytarowski@caviumnetworks.com>
> Signed-off-by: Zyta Szpak <zyta.szpak@semihalf.com>
> Signed-off-by: Slawomir Rosek <slawomir.rosek@semihalf.com>
> Signed-off-by: Radoslaw Biernacki <rad@semihalf.com>
> ---
>  drivers/net/thunderx/Makefile       |   2 +
>  drivers/net/thunderx/nicvf_ethdev.c |   5 +-
>  drivers/net/thunderx/nicvf_rxtx.c   | 256 ++++++++++++++++++++++++++++++++++++
>  drivers/net/thunderx/nicvf_rxtx.h   |  93 +++++++++++++
>  4 files changed, 355 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/net/thunderx/nicvf_rxtx.c
>  create mode 100644 drivers/net/thunderx/nicvf_rxtx.h

Patch is generating following checkpatch warnings:

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#234: FILE: drivers/net/thunderx/nicvf_rxtx.c:154:
+			sq->xmit_bufs > sq->tx_free_thresh) {
+

ERROR:CODE_INDENT: code indent should use tabs where possible
#421: FILE: drivers/net/thunderx/nicvf_rxtx.h:79:
+        entry->buff[0] = (uint64_t)SQ_DESC_TYPE_GATHER << 60 |$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#421: FILE: drivers/net/thunderx/nicvf_rxtx.h:79:
+        entry->buff[0] = (uint64_t)SQ_DESC_TYPE_GATHER << 60 |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#424: FILE: drivers/net/thunderx/nicvf_rxtx.h:82:
+        entry->buff[1] = rte_mbuf_data_dma_addr(pkt);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#424: FILE: drivers/net/thunderx/nicvf_rxtx.h:82:
+        entry->buff[1] = rte_mbuf_data_dma_addr(pkt);$