From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id E5F1EC12E
 for <dev@dpdk.org>; Wed,  8 Jun 2016 19:54:57 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga102.fm.intel.com with ESMTP; 08 Jun 2016 10:54:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,440,1459839600"; d="scan'208";a="971654134"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.53])
 ([10.237.221.53])
 by orsmga001.jf.intel.com with ESMTP; 08 Jun 2016 10:54:49 -0700
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
References: <1464540424-12631-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1465317632-11471-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1465317632-11471-19-git-send-email-jerin.jacob@caviumnetworks.com>
Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <57585BE3.3010308@intel.com>
Date: Wed, 8 Jun 2016 18:54:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1465317632-11471-19-git-send-email-jerin.jacob@caviumnetworks.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 18/20] thunderx/config: set max numa node
 to two
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2016 17:54:58 -0000

On 6/7/2016 5:40 PM, Jerin Jacob wrote:
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  config/defconfig_arm64-thunderx-linuxapp-gcc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc
> index 7940bbd..cc12cee 100644
> --- a/config/defconfig_arm64-thunderx-linuxapp-gcc
> +++ b/config/defconfig_arm64-thunderx-linuxapp-gcc
> @@ -34,6 +34,7 @@
>  CONFIG_RTE_MACHINE="thunderx"
>  
>  CONFIG_RTE_CACHE_LINE_SIZE=128
> +CONFIG_RTE_MAX_NUMA_NODES=2
Isn't this platform level configuration? And sets max numa nodes
independent from driver, right?

Can you please add some more information why this is required?

Also does it make sense to separate this patch from driver patchset?

>  
>  #
>  # Compile Cavium Thunderx NICVF PMD driver
>