From: Olivier Matz <olivier.matz@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mempool: fix local cache initialization
Date: Wed, 8 Jun 2016 21:14:52 +0200 [thread overview]
Message-ID: <57586EAC.7090304@6wind.com> (raw)
In-Reply-To: <1465398627-35022-1-git-send-email-sergio.gonzalez.monroy@intel.com>
Hi Sergio,
Good catch, thanks. The patch looks ok, just few comments
on the commit log:
On 06/08/2016 05:10 PM, Sergio Gonzalez Monroy wrote:
> The mempool local cache is not being initialize properly leading to
'initialize' -> 'initialized' ?
and maybe 'is not being' -> 'was not' ?
> undefined behavior in cases where the allocated memory was used and left
> with data.
>
> Fixes: af75078fece3 ("first public release")
I think it fixes this one instead:
213af31e0960 ("mempool: reduce structure size if no cache needed")
>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> ---
> lib/librte_mempool/rte_mempool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
> index b54de43..216514c 100644
> --- a/lib/librte_mempool/rte_mempool.c
> +++ b/lib/librte_mempool/rte_mempool.c
> @@ -787,7 +787,7 @@ rte_mempool_create_empty(const char *name, unsigned n, unsigned elt_size,
>
> /* init the mempool structure */
> mp = mz->addr;
> - memset(mp, 0, sizeof(*mp));
> + memset(mp, 0, MEMPOOL_HEADER_SIZE(mp, cache_size));
> ret = snprintf(mp->name, sizeof(mp->name), "%s", name);
> if (ret < 0 || ret >= (int)sizeof(mp->name)) {
> rte_errno = ENAMETOOLONG;
>
next prev parent reply other threads:[~2016-06-08 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 15:10 Sergio Gonzalez Monroy
2016-06-08 19:14 ` Olivier Matz [this message]
2016-06-09 7:57 ` Sergio Gonzalez Monroy
2016-06-09 8:03 ` Olivier Matz
2016-06-09 8:14 ` Sergio Gonzalez Monroy
2016-06-09 8:19 ` [dpdk-dev] [PATCH v2] " Sergio Gonzalez Monroy
2016-06-09 8:26 ` Olivier Matz
2016-06-15 13:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57586EAC.7090304@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).