From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id EFAF7558D
 for <dev@dpdk.org>; Mon, 13 Jun 2016 17:51:04 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga102.jf.intel.com with ESMTP; 13 Jun 2016 08:51:05 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,466,1459839600"; d="scan'208";a="986499510"
Received: from rhorton-mobl.ger.corp.intel.com (HELO [163.33.230.109])
 ([163.33.230.109])
 by fmsmga001.fm.intel.com with ESMTP; 13 Jun 2016 08:51:02 -0700
Message-ID: <575ED666.2010509@intel.com>
Date: Mon, 13 Jun 2016 16:51:02 +0100
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Zyta Szpak <zr@semihalf.com>, Thomas Monjalon <thomas.monjalon@6wind.com>
CC: dev@dpdk.org
References: <1464767771-19159-1-git-send-email-zr@semihalf.com>	<12994980.C5dFrG15Qg@xps13>
 <CA+E8-F0KdYROi7KkXmf_zjR+Y68oZAjqq0GFRKJUt_Uqowe7-w@mail.gmail.com>
In-Reply-To: <CA+E8-F0KdYROi7KkXmf_zjR+Y68oZAjqq0GFRKJUt_Uqowe7-w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register
	size in bytes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2016 15:51:05 -0000



On 12/06/2016 15:51, Zyta Szpak wrote:
>     I would prefer having only one function rte_eth_dev_get_regs()
>     which returns length and width if data is NULL.
>     The first call is a parameter request before buffer allocation,
>     and the second call fills the buffer.
>
>     We can deprecate the old API and introduce this new one.
>
>     Opinions?
>
> In my opinion as it is now it works fine. Gathering all parameters in
> one callback might be a good idea if the maintainer also agrees to that
> because as I mentioned, it interferes.

 From my perspective changing rte_eth_dev_get_regs() isn't a problem, as 
it isn't used directly rather than through rte_ethtool_get_regs()..

..Remy