From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 81CCD5958
 for <dev@dpdk.org>; Mon, 13 Jun 2016 18:27:40 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 13 Jun 2016 09:27:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,466,1459839600"; d="scan'208";a="1001001788"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.87])
 ([10.237.220.87])
 by fmsmga002.fm.intel.com with ESMTP; 13 Jun 2016 09:27:39 -0700
To: Beilei Xing <beilei.xing@intel.com>, helin.zhang@intel.com
References: <1462514861-29419-1-git-send-email-beilei.xing@intel.com>
 <1462514861-29419-3-git-send-email-beilei.xing@intel.com>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <575EDEF9.6070803@intel.com>
Date: Mon, 13 Jun 2016 17:27:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1462514861-29419-3-git-send-email-beilei.xing@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 02/29] ixgbe/base: add sgmii link for X550
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2016 16:27:40 -0000

On 5/6/2016 7:07 AM, Beilei Xing wrote:
> It adds sgmii link for X550.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
>  drivers/net/ixgbe/base/ixgbe_type.h |   9 +++
>  drivers/net/ixgbe/base/ixgbe_x550.c | 131 +++++++++++++++++++++++++++++++++---
>  2 files changed, 129 insertions(+), 11 deletions(-)
> 
...

>  	}
> @@ -512,8 +546,8 @@ s32 ixgbe_init_ops_X550EM(struct ixgbe_hw *hw)
>  		link->addr = IXGBE_CS4227;
>  	}
>  	if (hw->mac.type == ixgbe_mac_X550EM_a) {
> -		mac->ops.read_iosf_sb_reg = ixgbe_read_iosf_sb_reg_x550a;
> -		mac->ops.write_iosf_sb_reg = ixgbe_write_iosf_sb_reg_x550a;
> +		mac->ops.read_iosf_sb_reg = ixgbe_read_iosf_sb_reg_x550;
> +		mac->ops.write_iosf_sb_reg = ixgbe_write_iosf_sb_reg_x550;
Is it possible that these lines related to the patch 7:
[PATCH 07/29] ixgbe/base: change access method

It looks like first changes ops from ..x550a to ...x550 here and in
patch 7, using ops function instead fixed one.

Also if there is more details about ..x550a to ...x550 change it can be
good to add patch 7 comment.

>  		mac->ops.acquire_swfw_sync = ixgbe_acquire_swfw_sync_X550a;
>  		mac->ops.release_swfw_sync = ixgbe_release_swfw_sync_X550a;
>  	}
...