From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 2EC6D6CC0
 for <dev@dpdk.org>; Tue, 14 Jun 2016 12:54:56 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga104.fm.intel.com with ESMTP; 14 Jun 2016 03:54:48 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,470,1459839600"; d="scan'208";a="997255891"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.41])
 ([10.237.220.41])
 by orsmga002.jf.intel.com with ESMTP; 14 Jun 2016 03:54:48 -0700
To: Beilei Xing <beilei.xing@intel.com>, wenzhuo.lu@intel.com
References: <1462514861-29419-1-git-send-email-beilei.xing@intel.com>
 <1465887596-10346-1-git-send-email-beilei.xing@intel.com>
 <575FDE13.2060604@intel.com>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <575FE276.2000306@intel.com>
Date: Tue, 14 Jun 2016 11:54:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <575FDE13.2060604@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2 00/30] ixgbe/base: update base driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jun 2016 10:54:56 -0000

On 6/14/2016 11:36 AM, Ferruh Yigit wrote:
> On 6/14/2016 7:59 AM, Beilei Xing wrote:
>> Update base driver for ixgbe, mainly work on new features and bug fixes.
>>
>> v2 changes:
>>  Fix typos and update commit log.
>>  Separate [patch 18/29] into two patches.
>>
> ...
>>
>> Acked-by: Helin Zhang <helin.zhang@intel.com>
>>
> Series Reviewed-by Ferruh Yigit <ferruh.yigit@intel.com>
> 
Hi Beilei,

running check-git-log.sh scrip identified a few more issues in patch
subjects.

Can you please send a new version of patchset addressing following
issues, sorry for missing these at first review.

1) Unify "X550EM_A" usage in patch subject and commit messages.
        ixgbe/base: fix firmware commands on x550em_a
        ixgbe/base: add KR support for X550EM_A devices

"X550em_a" seems preferred in old commits.

2) Wrong headline lowercase:
        ixgbe/base: allow setting mac anti spoofing per vf
        ixgbe/base: add link mac setup for x550a SFP+
        ixgbe/base: add mac link setup for x550a SFP

mac and vf should be upercase

3) Line too long:
        Added support for the VLVF to be bypassed when adding/removing a
VFTA entry.

4) Wrong tag:
        Fixes: 86b8fb293fdf ("ixgbe/base: add sw-firmware sync for
resource sharing)

missing a " at the end.


Regards,
ferruh