From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D2B88C58E for ; Wed, 15 Jun 2016 18:25:47 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 15 Jun 2016 09:25:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,476,1459839600"; d="scan'208";a="719548751" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.133]) ([10.237.220.133]) by FMSMGA003.fm.intel.com with ESMTP; 15 Jun 2016 09:25:45 -0700 To: Stephen Hurd , dev@dpdk.org, ajit.khaparde@broadcom.com, bruce.richardson@intel.com References: <1465250923-78695-1-git-send-email-stephen.hurd@broadcom.com> <1465944971-113413-1-git-send-email-stephen.hurd@broadcom.com> <1465944971-113413-2-git-send-email-stephen.hurd@broadcom.com> From: Ferruh Yigit Message-ID: <57618188.8090804@intel.com> Date: Wed, 15 Jun 2016 17:25:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1465944971-113413-2-git-send-email-stephen.hurd@broadcom.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 02/38] bnxt: add HWRM init code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 16:25:48 -0000 On 6/14/2016 11:55 PM, Stephen Hurd wrote: > From: Ajit Khaparde > > Start adding support to use the HWRM API. > Hardware Resource Manager or HWRM in short, is a set of API provided > by the firmware running in the ASIC to manage the various resources. > > Initial commit just performs necessary HWRM queries for init, then > fails as before. > > Now that struct bnxt is non-zero size, we can set dev_private_size > correctly. > > The used HWRM calls so far: > bnxt_hwrm_func_qcaps: > This command returns capabilities of a function. > > bnxt_hwrm_ver_get: > This function is called by a driver to determine the HWRM > interface version supported by the HWRM firmware, the > version of HWRM firmware implementation, the name of HWRM > firmware, the versions of other embedded firmwares, and > the names of other embedded firmwares, etc. Gets the > firmware version and interface specifications. Returns > an error if the firmware on the device is not supported > by the driver and ensures the response space is large > enough for the largest possible response. > > bnxt_hwrm_queue_qportcfg: > This function is called by a driver to query queue > configuration of a port. > > Signed-off-by: Ajit Khaparde > Signed-off-by: Stephen Hurd > Reviewed-by: David Christensen > > -- > v4: > Fix few issues highlighted by checkpatch. > > v5: > Fix footer formatting > Switch to using the HWRM function descriptions from the source > documentation > --- Hi Stephen, I run basic checks on the patch set, mainly it compiles and applies fine, overall patch set looks good. Only get following checkpatch warning: Only v5,02/38 has one WARNING:MACRO_WITH_FLOW_CONTROL And my script caught following typos on commit messages: v5-07-38: mamagement v5-12-38: staitstics, asociated v5-14-38: fo v5-25-38: cleansup v5-28-38: arugments v5-30-38: wraper If there won't be a new version of patch set, perhaps we can ask Bruce to fix typos when applying J Thanks, ferruh