From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com
 [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 060AFC620
 for <dev@dpdk.org>; Wed, 15 Jun 2016 18:40:23 +0200 (CEST)
Received: from [10.16.0.195] (unknown [10.16.0.195])
 by proxy.6wind.com (Postfix) with ESMTP id C0A4B25059;
 Wed, 15 Jun 2016 18:40:22 +0200 (CEST)
To: "Hunt, David" <david.hunt@intel.com>,
 Jan Viktorin <viktorin@rehivetech.com>
References: <1465919341-3209-1-git-send-email-david.hunt@intel.com>
 <1465976824-83823-1-git-send-email-david.hunt@intel.com>
 <20160615121358.5ef9f142@pcviktorin.fit.vutbr.cz>
 <57614043.9090603@intel.com> <57614402.6020708@6wind.com>
 <576183AD.8070200@intel.com>
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, shreyansh.jain@nxp.com
From: Olivier MATZ <olivier.matz@6wind.com>
Message-ID: <576184F7.3040206@6wind.com>
Date: Wed, 15 Jun 2016 18:40:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
In-Reply-To: <576183AD.8070200@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v12 0/3] mempool: add external mempool manager
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jun 2016 16:40:23 -0000



On 06/15/2016 06:34 PM, Hunt, David wrote:
>
>
> On 15/6/2016 1:03 PM, Olivier MATZ wrote:
>> [...]
>>
>> The opaque pointer would be saved in mempool structure, and used
>> when the mempool is populated (calling mempool_ops_alloc).
>> The type of the structure pointed by the opaque has to be defined
>> (and documented) into each mempool_ops manager.
>>
>>
>> Olivier
>
>
> OK, just to be sure before I post another patchset.....
>
> For the rte_mempool_struct:
>          struct rte_mempool_memhdr_list mem_list; /**< List of memory
> chunks */
> +       void *ops_args;                  /**< optional args for ops
> alloc. */
>
> (at the end of the struct, as it's just on the control path, not to
> affect fast path)

Hmm, I would put it just after pool_data.


>
> Then change function params:
>   int
> -rte_mempool_set_ops_byname(struct rte_mempool *mp, const char *name);
> +rte_mempool_set_ops_byname(struct rte_mempool *mp, const char *name,
> +               void *ops_args);
>
> And (almost) finally in the rte_mempool_set_ops_byname function:
>          mp->ops_index = i;
> +       mp->ops_args = ops_args;
>          return 0;
>
> Then (actually) finally, add a null to all the calls to
> rte_mempool_set_ops_byname.
>
> OK? :)
>

Else, looks good to me! Thanks David.