From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 7F6CACC2A
 for <dev@dpdk.org>; Fri, 17 Jun 2016 10:09:08 +0200 (CEST)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1bDos8-0004Td-9R; Fri, 17 Jun 2016 10:11:24 +0200
To: "Hunt, David" <david.hunt@intel.com>, dev@dpdk.org
References: <1465976824-83823-1-git-send-email-david.hunt@intel.com>
 <1466080236-112618-1-git-send-email-david.hunt@intel.com>
 <1466080236-112618-2-git-send-email-david.hunt@intel.com>
 <57639F86.9050503@intel.com>
Cc: viktorin@rehivetech.com, jerin.jacob@caviumnetworks.com,
 shreyansh.jain@nxp.com
From: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <5763B018.5090602@6wind.com>
Date: Fri, 17 Jun 2016 10:08:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
In-Reply-To: <57639F86.9050503@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v13 1/3] mempool: support external mempool
	operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jun 2016 08:09:08 -0000

Hi David,

On 06/17/2016 08:58 AM, Hunt, David wrote:
> A comment below:
> 
> On 16/6/2016 1:30 PM, David Hunt wrote:
>> +/**
>> + * Set the ops of a mempool.
>> + *
>> + * This can only be done on a mempool that is not populated, i.e.
>> just after
>> + * a call to rte_mempool_create_empty().
>> + *
>> + * @param mp
>> + *   Pointer to the memory pool.
>> + * @param name
>> + *   Name of the ops structure to use for this mempool.
> + * @param pool_config
> + *   Opaque data that can be used by the ops functions.
>> + * @return
>> + *   - 0: Success; the mempool is now using the requested ops functions.
>> + *   - -EINVAL - Invalid ops struct name provided.
>> + *   - -EEXIST - mempool already has an ops struct assigned.
>> + */
>> +int
>> +rte_mempool_set_ops_byname(struct rte_mempool *mp, const char *name,
>> +        void *pool_config);
>> +
> 
> 

The changes related to the pool_config look good to me.

If you plan to do a v14 for this API comment, I'm wondering if the
documentation could be slightly modified too. I think "external mempool
manager" was the legacy name for the feature, but maybe it could be
changed in "alternative mempool handlers" or "changing the mempool
handler". I mean the word "external" is probably not appropriate now,
especially if we add other handlers in the mempool lib.

My 2 cents,
Olivier