From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 43F84CCD8
 for <dev@dpdk.org>; Fri, 17 Jun 2016 12:36:42 +0200 (CEST)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1bDrB0-0004cj-Mp; Fri, 17 Jun 2016 12:39:03 +0200
To: Lazaros Koromilas <l@nofutznetworks.com>, dev@dpdk.org
References: <1466074939-29863-1-git-send-email-l@nofutznetworks.com>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>,
 David Hunt <david.hunt@intel.com>
From: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <5763D2B3.2060407@6wind.com>
Date: Fri, 17 Jun 2016 12:36:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
In-Reply-To: <1466074939-29863-1-git-send-email-l@nofutznetworks.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 0/3] mempool: user-owned mempool caches
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jun 2016 10:36:42 -0000

Hi Lazaros,


On 06/16/2016 01:02 PM, Lazaros Koromilas wrote:
> Updated version of the user-owned cache patchset.  It applies on top of
> the latest external mempool manager patches from David Hunt [1].
> 
> [1] http://dpdk.org/ml/archives/dev/2016-June/041479.html
> 
> v3 changes:
> 
>  * Deprecate specific mempool API calls instead of removing them.
>  * Split deprecation into a separate commit to limit noise.
>  * Fix cache flush by setting cache->len = 0 and make it inline.
>  * Remove cache->size == 0 checks and ensure size != 0 at creation.
>  * Fix tests to check if cache creation succeeded.
>  * Fix tests to free allocated resources on error.

Thanks for the update. The patchset looks good to me.
I have some minor comments for patch 2/3 and 3/3.

One more thing: would you mind adding some words in
doc/guides/prog_guide/mempool_lib.rst ?

Thanks,
Olivier