From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0074.outbound.protection.outlook.com [207.46.100.74]) by dpdk.org (Postfix) with ESMTP id A62DA9AA6 for ; Mon, 20 Jun 2016 08:15:52 +0200 (CEST) Received: from BY2PR03CA047.namprd03.prod.outlook.com (10.141.249.20) by CO2PR03MB2375.namprd03.prod.outlook.com (10.166.93.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12; Mon, 20 Jun 2016 06:15:51 +0000 Received: from BN1AFFO11FD056.protection.gbl (2a01:111:f400:7c10::130) by BY2PR03CA047.outlook.office365.com (2a01:111:e400:2c5d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12 via Frontend Transport; Mon, 20 Jun 2016 06:15:50 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD056.mail.protection.outlook.com (10.58.53.71) with Microsoft SMTP Server (TLS) id 15.1.511.7 via Frontend Transport; Mon, 20 Jun 2016 06:15:50 +0000 Received: from [10.232.14.199] (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5K6Fk47005119; Sun, 19 Jun 2016 23:15:47 -0700 To: References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1466086011-11920-1-git-send-email-shreyansh.jain@nxp.com> <1466086011-11920-11-git-send-email-shreyansh.jain@nxp.com> CC: , , David Marchand From: Shreyansh jain Message-ID: <57678A3A.6020509@nxp.com> Date: Mon, 20 Jun 2016 11:46:26 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1466086011-11920-11-git-send-email-shreyansh.jain@nxp.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131108769508980834; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(24454002)(189002)(199003)(377454003)(2950100001)(65956001)(8936002)(92566002)(86362001)(586003)(68736007)(76176999)(87266999)(106466001)(99136001)(50986999)(54356999)(59896002)(65816999)(4001350100001)(6806005)(50466002)(11100500001)(69596002)(356003)(104016004)(230700001)(7846002)(2351001)(85426001)(97736004)(87936001)(105606002)(2906002)(23746002)(19580405001)(19580395003)(36756003)(47776003)(80316001)(81166006)(4326007)(83506001)(77096005)(110136002)(64126003)(65806001)(33656002)(8676002)(189998001)(81156014)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2375; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD056; 1:Lah1b/ffbFkxhPdKr0aOJt1sJYD2GpHMKE7N1Fmc7rxW2xr+i9spDQINvp8o3tVlkuexk/0opn40KcSCd8/cX9cELbf1CePOh2MQvcQiPlp9ZEU6/29MJlPwGoEuTNRPJagEi+d2nytSHx0mCZASyNMNKknTOmxs8XrOWGYymLwieY1aqAD0gnFZA32gL+64DdCVZbgkxkSH/VxSxLQ/pcAl56uSdJV2F+Tlgqv71STU2ZNMxBcMhcm5DaQtiQNpl1k4KDhuisSwAGUaVdkbJ6TDduGALo6k473E92ncz+mu2+fRR4vWQjpPvBFo5lLdUTUtxDACq8zKmAyS0z6LH2cBV3CKugvfvq3zgSJXNnaFyU1TY5YiwqRrDZT64K8h9v/+NKgTm09m6lFHpx6Qn7/+JOW5IXv9pOtEbwQTCzIl8yteC82D7geqfanxtV6MfqIqusLhmpRcc3b1SftU5NqZwk1D+hmriwUMs0coc8tPIWboCNb3+X6DKLENQ1t9E2lys9LLfXOQts1urVzJn/mb2ICp2zLj7yvTvZsR0gdeI5HehREp5VHuzcDqF9jH X-MS-Office365-Filtering-Correlation-Id: ac1da4a5-1ed7-49c6-6d7a-08d398d253e9 X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2375; 2:s1BcR0LfsZ+npHnYvbXPLc1fpR3+/Yc9X8QHKCYfhaQ+Yqz9A6otcMMPceL0fWCQsx4eDHnCfjcNJJq2RTuuuCHIDl37Pm8PM/jP8LqolOKI44dqwAIlQoM8SwMVw1VoqKX+RGtvaDjBF4WTah9LoP9nQjYw1D1RWc7dHSAt9b0KBUbZiJvHT8GjbwDfeoD+; 3:amwMml7lX86FMuBIdN7RuWPBE3oBpDoMT4f0AxuIkRi5I6B1EMc5yRD/diEOtyLjqE2bfIjUEbOQJCz4vLU4x93pcDiSECZh59RG0hfkpD33xJ+RV2R1f/x/mkUqsYjH7LucbLln5hlW8aM21N/qzD2MkmBAjuQGwWWBlU8BhtyXV+o626AHQU3xFtJJ7ej3CR397qKTMZTKv1Jx/vKB2Gka1B14giPpQk0NidUW1lE=; 25:3fjStJJPoNxIj5+eQ1+dTnIpTYULleHSr+Xa7I7UudPqOWAMbn1FUUioa8ct/1jY2Vnz36WA4mudE00QJsZvKDNpEj1kwnjkWXuy8+H2NAxXVWQXjR+AEpwiw8b8WaNsJl84axt0qeRoNMB8JSHUwbmQeY6JCIojzNIJp2mqoyEQ40N8vgtmXbaB6PNomS+08P/q3R+70h8gXltbtm4l3poF18U26oE9ceutK3Q6FXC9/hOfVeb+CPU6S8ZXkVMRPQm5TpPGF6QbU4sBFQ3S7wXsG2x0TO58QQToDpHu3Aj3QcoO2D6bZ1MT5ASg48dWeqlNVjq6oO2za27NR65tV1zMFSdxXIX24qT+g573ue4aCiJBy6jVL6EDz8tVbAIS0h7LUCKYZaPMw2YZHl9zo3hAqkKG8KPoCUDT9jEgFws= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR03MB2375; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13023025)(13015025)(13017025)(5005006)(13018025)(8121501046)(13024025)(10201501046)(3002001)(6055026); SRVR:CO2PR03MB2375; BCL:0; PCL:0; RULEID:(400006); SRVR:CO2PR03MB2375; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2375; 4:4L5USPx3Z9lkC2Kxb6BvTWmqikuisVfgPDdafl7gBQHKg9Nx0cAE1pju+jD+Fj2JkcIolLlU4IlcPttICcQjXPWdSt2a8cmt3hm7DQ0BB48eLDdeN3h+iTTidiTsVq4obwril25d1IVjBBTwTGr0hzoGCq4AHt3NSJzT+/vLAMEbdnQJ6KQ9fZwauKiIJ1ztuxD0hgguQLxOWAK0tfPKW25HgEtvN0W8yYNN6tdMQKH+cUlJzU4pf6J86Pex5KTNiTtDU/SJwtIJuFbJpuM3ulZI8cIHSTx7Roi4NWJpACthg1/rb/19Us2TU/bRx+gQQutAu8K8nNk6DbHer/f5t/qPJ0Pcz/hp5oPEQN31mb0aBcYl6rdPMFJKgZg5Zu6000O67xqFmmgfPBo0OOxApbbA1Urgi33Ndrh9qyc2KtGD1QgUikROMtVzf2jkD+ufaozJJb7U+BJdhRP+5r00/JpEOJJ26KW/2FU5qk0xOME= X-Forefront-PRVS: 09796A1B83 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CO2PR03MB2375; 23:mLy7mUpsl00+Y//7ZYJraroxn2e1FrrxRw22K?= =?Windows-1252?Q?C6Lk0f4ZSInN6sjLpGav2qLnaa19pnCiBb13JG3sg0Pc3aPijpBS0h5B?= =?Windows-1252?Q?UdavcLfTWHTSFZ4tdgJWt6dKXASrvIC97HbH7ngVS8RW1ezRjxP9di9y?= =?Windows-1252?Q?rsrhywWKKOBwiA6uH6SED3H5MVIygPuNq3iZPxqRVf1xkKjb5Ci5To5p?= =?Windows-1252?Q?5iZhAddyRTAOdqWIFxzZhYU8LgB3otieL0QoAgHau0lqhaSrLeX1CBcr?= =?Windows-1252?Q?znBONjYMbREX/4/nBiIEwNvrnR7BNtugM6pEIdlKnriKy7v3r/GFGBm5?= =?Windows-1252?Q?wgOXki3YsGMxYPa1/1XUymSuQ7AdgOkMaFsz4hfJ+furi40CGzW1TBI0?= =?Windows-1252?Q?EfsQvgum38n0WPLlgjkozLAkZxO8aKqwwa2CnoAERG5Bl1HKqwaeO6G8?= =?Windows-1252?Q?p1FRKKUTcFaJHsMcIBNJk0t3lB9wr8twaZbMGh4ua1ZSuxyQ07WA43Ik?= =?Windows-1252?Q?Xde6sExZ2VOXWHjnxJhp3yMdSPoSfjfhIggt/4881+6gc9kYYQ3R01Kh?= =?Windows-1252?Q?chmNF7L6MTS+etALlpVNz/EIh+U4yOWttDENWec9PdBZ77qAfrrLk6QQ?= =?Windows-1252?Q?+r3Y1ljk9E4LiTrJyl6/wIb2Cf/MX7KuyoiNR8ERd8fgwhQnnZn5cKI7?= =?Windows-1252?Q?qaw+3t5wYYV0DEQvMgAnRFtd/nqakMBwI4XPrrp+NVPv5GuMMwawtYJP?= =?Windows-1252?Q?TnJBq14y1P3g+HoC3z+B0fBwwlxnt9bZeuTtG7sl7QDfPkOfCLSjVtvQ?= =?Windows-1252?Q?GhePjP442rEM1deWGEg/pUZXCYPKWEl5TCoSGae113zrljpCdsbV098t?= =?Windows-1252?Q?chnxXUACdFveziKEa9aGWijfJDMDXaXnuCn2hk0o4tD/a87TFGUcDf+C?= =?Windows-1252?Q?e8wmJ3xVc5dNTzWMIf9CSC25STUqVYvRQZhhluzJJr2pqREVEIaY+dfx?= =?Windows-1252?Q?/NWjFTFwln8sQk6iplaYizBtT4KYJN7T/4eb5QZyjEMKi0JCpEedfI7o?= =?Windows-1252?Q?w4qvc4dBELNJ3WuI8mFvT5PjWuvN7itjFKRKteUWGwCzMHbrHxEZTXAj?= =?Windows-1252?Q?ae+yN+QWXWl7cxIYGHPEVsIG2Ukn4HBZmrpSa9fPNn2x1PWMii8UVswc?= =?Windows-1252?Q?WTkX6HzPIVzMgVLpzFoBR4RQfAR55+NxbCZkuKVninw4fPN4E+2qmLYA?= =?Windows-1252?Q?NrpdXUj5coi0AJuxaAxzDB4rhoYyfuyVv79XVeRhOXXlPJLHukRglrYd?= =?Windows-1252?Q?7IUPM9ws/LrFyzsgZ+AhNiAWdtRoVm56I8/toGAz38kY4uOdOVd+QgFj?= =?Windows-1252?Q?ngfYv+BDgovwOUQZ5h9VyAzNa0OavTgNJjGxc82yrrhg1+Ofv6Ygukb6?= =?Windows-1252?Q?ioryCChaWh7BgrcXNhuGqGURdFqy1wHJ9VWxO8Nrkq2Q+SsppFV3ohSU?= =?Windows-1252?Q?m8inME=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2375; 6:mXy6GJam3c2UyzL+LiqmVKY9cKU0Y6BueHvmM3XSGHayfa9YVyfobDRiCHoRIh8CnzQdxlaMHsowc29ssxAu4iHPDQ8bqAwpafwLreHfDve2nX1x8QlGHuL7nJQecM5Rr0CeP5TS2I/Zj0IRmSAwj/U8fRG8No1nB/XtUzoqOtoq9p6VsZ1nExTv/hyDXAnXG9/VD+nK2PM85/rfNOxRNfqPUY/leAW+IHFGJ/bK1a3ZqQyMxSOWUFww/IIi4nsJyIm5oa5Hy2NtH9BrrZ6tbROHNVOhHLwKAaSMziNfEnw=; 5:h2EIFC152LKhzmy+NGCJAqQQ4Y91w1/6nygOpLL1/7nlvU5zcHO9UlW//AEaJP2Tn7P744x5RDF59ltftG9Av/9W1E4h58zuK4Pcr2V4bUZZU03XpwdpOU8WZurdn349YHX4xiV30NREEm2l8FcvlxIulO7u2OT7YHrzpOu3suM=; 24:Bq8xu5uiikgRvRH4VweyDVUl1Vgi9LRfVM/q/eUB6QXqYb7g2mHZu5saGWicnv88NMI3epnhH1EjUY7J0kEmRuMKhRSVbQ3e4GXubZklwLQ=; 7:7wosUfLmWGcKrXPRt9COLnhAQ28zHy5l0+lqKq4u3iCrTzofi/5rr36WR+sn4yVi+QfwOEH33TU77zIaJvUNhRsvqShwwo7O7cUmly4uwWcC+31krLM6cxvfQC0sjGjXjC1pkbc5A2AwfbMaqf/+byLrwS8xZWUSYSbulPSOwD2JZwFiiocYnHA8yCrdkMDhs5EpbE3T/O0opCSE77Pk4m+0LNHhcpN7IfnZEtdZZtBuewrxYC92SHEcYy9RRFy+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2016 06:15:50.5548 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2375 Subject: Re: [dpdk-dev] [PATCH v3 10/17] ethdev: get rid of eth driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 06:15:53 -0000 On Thursday 16 June 2016 07:36 PM, Shreyansh Jain wrote: > From: David Marchand > > Now that all pdev are pci drivers, we don't need to register ethdev drivers > through a dedicated channel. > > Signed-off-by: David Marchand > --- > lib/librte_ether/rte_ethdev.c | 22 ---------------------- > lib/librte_ether/rte_ethdev.h | 12 ------------ > lib/librte_ether/rte_ether_version.map | 1 - > 3 files changed, 35 deletions(-) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index d05eada..7258062 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -334,28 +334,6 @@ rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev) > return 0; > } > > -/** > - * Register an Ethernet [Poll Mode] driver. > - * > - * Function invoked by the initialization function of an Ethernet driver > - * to simultaneously register itself as a PCI driver and as an Ethernet > - * Poll Mode Driver. > - * Invokes the rte_eal_pci_register() function to register the *pci_drv* > - * structure embedded in the *eth_drv* structure, after having stored the > - * address of the rte_eth_dev_init() function in the *devinit* field of > - * the *pci_drv* structure. > - * During the PCI probing phase, the rte_eth_dev_init() function is > - * invoked for each PCI [Ethernet device] matching the embedded PCI > - * identifiers provided by the driver. > - */ > -void > -rte_eth_driver_register(struct eth_driver *eth_drv) > -{ > - eth_drv->pci_drv.devinit = rte_eth_dev_pci_probe; > - eth_drv->pci_drv.devuninit = rte_eth_dev_pci_remove; > - rte_eal_pci_register(ð_drv->pci_drv); > -} > - Self review (as I rebased this series): With this applied on master (3901ed99), it would cause issues with qede driver. qede driver uses the rte_eth_driver_register() function. I will update it (qede driver) and post another version. > int > rte_eth_dev_is_valid_port(uint8_t port_id) > { > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 6deafa2..64d889e 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -1842,18 +1842,6 @@ struct eth_driver { > }; > > /** > - * @internal > - * A function invoked by the initialization function of an Ethernet driver > - * to simultaneously register itself as a PCI driver and as an Ethernet > - * Poll Mode Driver (PMD). > - * > - * @param eth_drv > - * The pointer to the *eth_driver* structure associated with > - * the Ethernet driver. > - */ > -void rte_eth_driver_register(struct eth_driver *eth_drv); > - > -/** > * Convert a numerical speed in Mbps to a bitmap flag that can be used in > * the bitmap link_speeds of the struct rte_eth_conf > * > diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map > index 31017d4..d457b21 100644 > --- a/lib/librte_ether/rte_ether_version.map > +++ b/lib/librte_ether/rte_ether_version.map > @@ -80,7 +80,6 @@ DPDK_2.2 { > rte_eth_dev_vlan_filter; > rte_eth_dev_wd_timeout_store; > rte_eth_dma_zone_reserve; > - rte_eth_driver_register; > rte_eth_led_off; > rte_eth_led_on; > rte_eth_link; > - Shreyansh