From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 88AE8AD82
 for <dev@dpdk.org>; Mon, 20 Jun 2016 18:16:36 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga103.fm.intel.com with ESMTP; 20 Jun 2016 09:16:35 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,499,1459839600"; d="scan'208";a="979750679"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.97])
 ([10.237.220.97])
 by orsmga001.jf.intel.com with ESMTP; 20 Jun 2016 09:16:34 -0700
To: Jan Medala <jan@semihalf.com>, dev@dpdk.org
References: <1466099690-28085-1-git-send-email-jan@semihalf.com>
Cc: Alexander Matushevsky <matua@amazon.com>, Jakub Palider <jpa@semihalf.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <576816E1.6000302@intel.com>
Date: Mon, 20 Jun 2016 17:16:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1466099690-28085-1-git-send-email-jan@semihalf.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] ena: Update PMD to cooperate with latest ENA
 firmware
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jun 2016 16:16:36 -0000

On 6/16/2016 6:54 PM, Jan Medala wrote:
> This patch includes:
> * Update of ENA communication layer
> 
> * Fixed memory management issue
> 	After allocating memzone it's required to zeroize it
> 	as well as freeing memzone with dedicated function.
> 
> * Added debug area and host information
> 
> * Disabling readless communication regarding to HW revision
> 
> * Allocating coherent memory in node-aware way
> 
> Signed-off-by: Alexander Matushevsky <matua@amazon.com>
> Signed-off-by: Jakub Palider <jpa@semihalf.com>
> Signed-off-by: Jan Medala <jan@semihalf.com>
> ---

Hi Jan,

This is a big patch and hard to review, is it possible to split patch
into more logical pieces? List in the commit log is potential for
splinting into.

Also there are small checkpatch [1] and check-git-log [2] warnings.


[1]
### [dpdk-dev] ena: Update PMD to cooperate with latest ENA firmware

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional
statements (16, 16)
#568: FILE: drivers/net/ena/base/ena_com.c:2549:
                if (unlikely(!host_attr->debug_area_virt_addr)) {
+               host_attr->debug_area_size = 0;

WARNING:LONG_LINE: line over 80 characters
#1026: FILE: drivers/net/ena/base/ena_defs/ena_admin_defs.h:1806:
+               (val <<
ENA_ADMIN_FEATURE_RSS_FLOW_HASH_INPUT_ENABLE_L3_SORT_SHIFT)

WARNING:LONG_LINE: line over 80 characters
#2229: FILE: drivers/net/ena/ena_ethdev.c:357:
 +               (DRV_MODULE_VER_SUBMINOR <<
ENA_ADMIN_HOST_INFO_SUB_MINOR_SHIFT);

 total: 0 errors, 3 warnings, 0 checks, 2291 lines checked

0/1 valid patch


[2]
Wrong headline uppercase:
        ena: Update PMD to cooperate with latest ENA firmware

Thanks,
ferruh