Re: [dpdk-dev] [PATCH / RFC] sched: Correct subport calcuation

["Simon Kågström" <simon.kagstrom@netinsight.net>]

Hi again!

Any news about this patch? I'm off for parental leave starting next week
(until january), so any comments (or simply dropping it!) would be good
to have before that :-)

// Simon

On 2016-06-10 08:29, Simon Kagstrom wrote:
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> ---
> I'm a total newbie to the rte_sched design and implementation, so I've
> added the RFC.
> 
> We get crashes (at other places in the scheduler) without this code.
> 
>  lib/librte_sched/rte_sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index 1609ea8..b46ecfb 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -1869,7 +1869,7 @@ grinder_next_pipe(struct rte_sched_port *port, uint32_t pos)
>  
>  	/* Install new pipe in the grinder */
>  	grinder->pindex = pipe_qindex >> 4;
> -	grinder->subport = port->subport + (grinder->pindex / port->n_pipes_per_subport);
> +	grinder->subport = port->subport + (grinder->pindex / port->n_subports_per_port);
>  	grinder->pipe = port->pipe + grinder->pindex;
>  	grinder->pipe_params = NULL; /* to be set after the pipe structure is prefetched */
>  	grinder->productive = 0;
>