From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ernst.netinsight.se (ernst.netinsight.se [194.16.221.21]) by dpdk.org (Postfix) with SMTP id C47C76CCC for ; Tue, 21 Jun 2016 08:41:03 +0200 (CEST) Received: from [10.100.1.152] (unverified [10.100.1.152]) by ernst.netinsight.se (EMWAC SMTPRS 0.83) with SMTP id ; Tue, 21 Jun 2016 08:41:39 +0200 To: cristian.dumitrescu@intel.com, stephen@networkplumber.org, dev@dpdk.org, thomas.monjalon@6wind.com References: <20160610082913.4878ab77@miho> From: =?UTF-8?Q?Simon_K=c3=a5gstr=c3=b6m?= Message-ID: <5768E17A.4060404@netinsight.net> Date: Tue, 21 Jun 2016 08:40:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160610082913.4878ab77@miho> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH / RFC] sched: Correct subport calcuation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 06:41:04 -0000 Hi again! Any news about this patch? I'm off for parental leave starting next week (until january), so any comments (or simply dropping it!) would be good to have before that :-) // Simon On 2016-06-10 08:29, Simon Kagstrom wrote: > Signed-off-by: Simon Kagstrom > --- > I'm a total newbie to the rte_sched design and implementation, so I've > added the RFC. > > We get crashes (at other places in the scheduler) without this code. > > lib/librte_sched/rte_sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c > index 1609ea8..b46ecfb 100644 > --- a/lib/librte_sched/rte_sched.c > +++ b/lib/librte_sched/rte_sched.c > @@ -1869,7 +1869,7 @@ grinder_next_pipe(struct rte_sched_port *port, uint32_t pos) > > /* Install new pipe in the grinder */ > grinder->pindex = pipe_qindex >> 4; > - grinder->subport = port->subport + (grinder->pindex / port->n_pipes_per_subport); > + grinder->subport = port->subport + (grinder->pindex / port->n_subports_per_port); > grinder->pipe = port->pipe + grinder->pindex; > grinder->pipe_params = NULL; /* to be set after the pipe structure is prefetched */ > grinder->productive = 0; >