From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 0DCD8ADCA for ; Tue, 21 Jun 2016 11:55:16 +0200 (CEST) Received: by mail-lf0-f46.google.com with SMTP id f6so15344196lfg.0 for ; Tue, 21 Jun 2016 02:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=qdgPNqgGUEBchRvfsjUEBoe3xm+riYC+d6ymXVyKH70=; b=X792lOwCQEwjK/ygfquKFBrzLqZSsCAC+ijeCFieaPYFJEX+7tBZAvKhdZ3DXeiY+r cPwRyUgf9m0+YFDWirBALAj8A2TjPfDYnA77/OIYqpj1z7k7qgeaAjgTnXY/QwqX5YyD I5cpaao97paUNPWiMtx+eco0lJMX62syX1umbDNovPfhtRZeffE38m7mCuSJCEdiWKUQ LvZcx0ejeSd4p4Xrgxiiyy7W4sL7PtawuygAWa5v/QjttguxscWG6eAhScHcocVZRfRs OP1A/fKIXFVbh5JnWB5dRf+eb00CZ9zDhSy7YxASdy7jiYrzD9v8Yc0evwy6MxIANo1q x/sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=qdgPNqgGUEBchRvfsjUEBoe3xm+riYC+d6ymXVyKH70=; b=RHoRz1EDWZgHUIWT9NTXuE5r5vmtWnFnuoWQ6D1a/ffhGaga1AT6MdXxUgLkcl9p1r GGNH20eRTNuKmdAWuhNRVWXsiAWD6R8bKb9K3C1ndP09iCIEtsuOOzB0CkEFYxHHxfBg cMLbrDZnQZikOEEjptaIQ+KiNtapuQq4R5lUl8mV3DcpzxaWtsE7dkhcDTWwT08dDNCN tGgTSzwGN5jhmbFD6hLvc4W9k7LrEeLkbhel6gP2maYSoc2rkR1RT2CCJUgGbDOR3wpp AWabbWrrwFrM6sjJY+66DdhtwsucjkLk+yfqU9+mxjUQuihPiASmVerIaA0MxtO00ThZ 8GDw== X-Gm-Message-State: ALyK8tJAdpBvzNco0GMqnypCMD0/e7lriyt0C84pohJ/D0J2Z7JvolciivYKRDpU/cHHcw== X-Received: by 10.25.27.206 with SMTP id b197mr4781941lfb.218.1466502915716; Tue, 21 Jun 2016 02:55:15 -0700 (PDT) Received: from [10.0.2.212] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.googlemail.com with ESMTPSA id g28sm6897922ljg.24.2016.06.21.02.55.14 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Jun 2016 02:55:14 -0700 (PDT) To: Thomas Monjalon References: <1464767771-19159-1-git-send-email-zr@semihalf.com> <575ED666.2010509@intel.com> <1667158.opORKPN5aG@xps13> Cc: Remy Horton , dev@dpdk.org From: Zyta Szpak Message-ID: <57690F01.6020600@semihalf.com> Date: Tue, 21 Jun 2016 11:55:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1667158.opORKPN5aG@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 09:55:16 -0000 OK, I will do the v4. On 17.06.2016 12:20, Thomas Monjalon wrote: > 2016-06-13 16:51, Remy Horton: >> On 12/06/2016 15:51, Zyta Szpak wrote: >>> I would prefer having only one function rte_eth_dev_get_regs() >>> which returns length and width if data is NULL. >>> The first call is a parameter request before buffer allocation, >>> and the second call fills the buffer. >>> >>> We can deprecate the old API and introduce this new one. >>> >>> Opinions? >>> >>> In my opinion as it is now it works fine. Gathering all parameters in >>> one callback might be a good idea if the maintainer also agrees to that >>> because as I mentioned, it interferes. >> From my perspective changing rte_eth_dev_get_regs() isn't a problem, as >> it isn't used directly rather than through rte_ethtool_get_regs().. > Zyta, would you like to make a v4?