From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0075.outbound.protection.outlook.com [65.55.169.75]) by dpdk.org (Postfix) with ESMTP id 7B137C366 for ; Tue, 21 Jun 2016 14:31:03 +0200 (CEST) Received: from DM2PR03CA0027.namprd03.prod.outlook.com (10.141.96.26) by CY1PR03MB2379.namprd03.prod.outlook.com (10.166.207.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12; Tue, 21 Jun 2016 12:31:02 +0000 Received: from BN1AFFO11FD045.protection.gbl (2a01:111:f400:7c10::173) by DM2PR03CA0027.outlook.office365.com (2a01:111:e400:2428::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12 via Frontend Transport; Tue, 21 Jun 2016 12:31:02 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD045.mail.protection.outlook.com (10.58.53.60) with Microsoft SMTP Server (TLS) id 15.1.517.7 via Frontend Transport; Tue, 21 Jun 2016 12:31:01 +0000 Received: from [10.232.14.199] (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5LCUwps017922; Tue, 21 Jun 2016 05:30:59 -0700 To: References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> CC: , From: Shreyansh jain Message-ID: <576933A9.5010701@nxp.com> Date: Tue, 21 Jun 2016 18:01:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131109858620529303; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(24454002)(377454003)(356003)(7846002)(105606002)(47776003)(87936001)(65806001)(65956001)(106466001)(2950100001)(50986999)(54356999)(92566002)(76176999)(4326007)(86362001)(87266999)(2906002)(2351001)(8936002)(230700001)(85426001)(65816999)(50466002)(59896002)(81156014)(81166006)(8676002)(586003)(68736007)(11100500001)(36756003)(23746002)(83506001)(15395725005)(104016004)(33656002)(6806005)(19580395003)(69596002)(4001350100001)(110136002)(99136001)(5890100001)(80316001)(97736004)(77096005)(64126003)(189998001)(15975445007); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2379; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD045; 1:cJ4KXMpP7x+mloHtfcL+DTB655SROiyRdBaccw4y3mzKffsPg6kjVmI3MgJZchchtKfesqZE+wH8EYTk888LxiAefeVmdy4KChOQ/8SmYz8t0c87GeDoPzOn9nlRRrCisN5lyUcmiaNUZAe4nrW3NO2nGC173TYkweAoMaF7fNGe3Mk77P1AdSppddp9zjFMO2RcdHsTAYK3vx53vycO3Mj0D6UZon+u67qZJVm7Q5kFMOlgjCEbLCTpVOVJabHci5nMqNAXObx+ib4RAfLB04MdzeUr8cMA6g2YbDBn//K3w8Hh4C2k/qQNzKGVmVH3iBf4xhFQJ+Igk4wfo8bLDwcB2gsdX7B7G01YbOA7xOoKy3k1MPyeWPkpj0mZbOXtsK9neNHExzwJL8t8rKHWz+v6y65lE173b3QZeoDumb6rJ96w+ZJgGlpW1T76LTkcXwzR99NbA0HbEKL3NW1XOiiVDqGaYo01ueWRxn/OUy3m2Xms0hRgdx2T6Wu44zeS/3RbHXvlsY9PwnmfcF6LzNayVNdVT7o6DE9iVNpcvviIN9DuMmXFN7pGNk7P1NLb X-MS-Office365-Filtering-Correlation-Id: 4b893472-a021-4660-da97-08d399cfe817 X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2379; 2:wC/KQNXDTNJkc/pPDjRjGmJDMFMTHOwWvH0ty5Tdm/nUlqY2Keprj34haIe0mtUo8EM6nJh19z6zy5rg8OWn51x4lxTiuQbOoBdaGMBC7jj5M4qHg0QMSHcezwBFAA99QmFOecEyMOM0DxzG/258RzktZOmRHCW4fF4wBnAHT9iwd0hdhan/MBnP14vN5GVZ; 3:7tU4iCm7wQ8ReyvOc64E58wIAGv0O33PqyE7MvfpkL+BX3QIIBy8ZGuaXTrHgOLJC2ghG4tXJa3bw5qgDbQFUFP35iBP6cwSJTDk/WMj6nSzvr1FtcSeoilRtucBgcftWgRattw6aCRXCh5gae/kAIIf0pVP6sqYDdxG/PJYDZpPWQbdV4lEJB8rLKLAya1LHQgp2owXKkATs7vgE+MCgLmpa+T6ZBsFfDWKFSOjqGk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB2379; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2379; 25:SjgdWHGAQXCc+zKTVtM8myYOPLeoov85JK3e73YJXVsANmDBqqJW6hj/0ayZxXeKXt12bbbtMZYUBsS0i7/oS7DLDpoKLpToVRZ3Pu975UOEk4PQEtH6KdLdkjEurITXPdpJ+Cp7QFmcl3GACjui4683xp2faD8wIAbzVa3l2lGeUMxXZu4wPbbYOqIwpA1zXtT8kO1iNvGO8vPWlqhybIUeWTrn3nmNDYv8aGkE3bKryyOYQZ+W5Dl9qiC8vfCe4CZQ084g7vG51DbQqPrOyXGpJ8am7jAXeMSnQFPdOAcm+tpSFYlOe7VifOc11xkRkjaWwdrL9oS6IGjz2m8u0vxbk1SDtQN4DjHfolCfHF3n51FYGTjHHV5PGrjp2+qq31DDf/mAD4rg1M1ZXTUW/eqhVmePsZUNtnDty9RYC0bNyVUKppXPr1dPExIdX8WmWcbq6N/SG2Gk1Hdh9Qaou16FZFOcpfa7sBr1HS6t3CrmTv6hg/dYpL3OPZvvuJzixg9AKqVTDph6snrhiiMvyukUWM+Jy+hAGpHm+MRCr7IQTFJRU/CeIuieID4UMudl/XfIcKOfJGTRbZFhKlE3FUkwoikfKGOzw/DQQTv4dmWMK+u+xafF3TnQqAiI2kEgMX4JQ/vM9j//3wHv1lt1NSsY76W5y9eMSNJu4cej/CSepFQp8t0plpN3Bq6s5qkHqD0wtckg0s53Ot3bFy0rTAg404n/6BrDZphmo5eFULd/7At5j8roMaI7k3hm8ztKS9maP29bFqMfUWwFnF32KxgsG5NVK98b3So2iV6ihfKdMOjWEkWTDwKrx2qFrowmZqrDZY8ssPLzQsYA8lw1Hw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13017025)(13024025)(13018025)(13015025)(13023025)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:CY1PR03MB2379; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR03MB2379; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2379; 4:DVPg5YBW8e97P+1RWyyXAUy1Jc8uEa5g6YS8G+70N7X9cpFcNpYj/qHIZni+T1PqTDfLNjDDD5KrgxEbrq9e40LWBnemE1XnbxutFVShBGU34V140Ga8iy8T2qdMsB+cXNFQexVIbQU9xIPZgOsa+oBBCNpQMsBcbvJ3XJTHGMYnjHWjCR/klakkM5kPdOiHxTWvKgd19PiGWsr8mrx5QdydeqLWvwHLZzqclnDnBk/umKNZR7odT5UaBSvItzScnq/R3Mjc29yPX7+TBlUuXiuaREjvboQr5qGnRDJygICG2ltTGX/F9Jyb8sI/jrejJBce9DQVdF2lThQ/BbtgaEW8kczyYxVu0rTl0R6G92iHr3CS2mpWc1G7JAl8OcgNW7PYYl37JueuMtEh3XgS14KQ7n64BElKNGtMkijMQF/hKnKZOAJ1s87Qv1zsDj2LtKVCvV0wO2oJIi17JFqCB45vGa8Lph7Z7Rn3C5OoxqQ= X-Forefront-PRVS: 098076C36C X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY1PR03MB2379; 23:jJNYCmN/DMTJ98BvjpcGUXTjHoBJXJVnO8aMZ?= =?Windows-1252?Q?jgULKfFlQdtvULEosE8kDSk2FMDZXNPAhJKO8oTV/c+N5iVNYIV4REPT?= =?Windows-1252?Q?fHFOi5m7l7YmJRkwe7lKYr8adt0hjIdo+4C9vPKS5F6/Aad00QiaOFv7?= =?Windows-1252?Q?GTxODPnbURacuLq49gXLl4KyCLfcqS0sQmBmka06lBE26c9srER6PRcA?= =?Windows-1252?Q?z/NTudcg3eA8BYN4qf3UDKeloaJD0fCXRNx9qOJpELSzrB1aiNilOJt/?= =?Windows-1252?Q?fC/lnkLBDWsxQI5LL9vsVgynNNCYHbGMqtaEM0bv/i4O7LAVrbG9UTlP?= =?Windows-1252?Q?LXjPz9Twvkj1p221HYjTjihOVggfqCeKTenpNbradQhRDtgMvSSvkp9O?= =?Windows-1252?Q?cf3e9kHBKyF5w5s3+7HF+cC/j7oU/9vpgtW5q7xKAjzgaBgOqFq4ebme?= =?Windows-1252?Q?tbZWoVAqAlxlKGno66Mmht3FdwgEw3lZkJATnG9H/oRjxzgVkVsBPEdU?= =?Windows-1252?Q?CoqyPgOZdideTAJ5jMDt8MLqJQx3ME1b4jtjCig5D7kCn5YFE3K/13uD?= =?Windows-1252?Q?iz1cIrz4K79KYUL3wlASW2F+pfKyU+DGpBqNB4NeXuWUjmOaQr6Kdu0u?= =?Windows-1252?Q?KmapkaKzPWj0qIH8p3WhvwyGcdgmqSRHbXifFZEsDlfJI4gdceugrCQq?= =?Windows-1252?Q?FDHy5Snb8cfCgqGOZbPepJiOjQf1EN4OwMTAVIx88aaFO3P/EcsHFCKK?= =?Windows-1252?Q?BuWdntHXq+MVIfv07ao9hAEo51zcB3Pi2Ueyid9fw1Mk3NCBQ50YnqPE?= =?Windows-1252?Q?W7IGYyUrqKI06ZWcYX5dH7OU9P2ylPw5L1FEK8tVKyWYgQ7j/EgMhnuU?= =?Windows-1252?Q?vraAYDg8EvNhSDZCuzDUEHW4EeQLys/mSvPmncGkyQKfEtyEQFTVySTo?= =?Windows-1252?Q?JydCKVcllaC0lUTg+dV0mwIScRXr/CyHIc3nppXRXBC1/C5Jd60H5SWG?= =?Windows-1252?Q?eGr7E5Vq+ffqg4VdoJ5u481Xk3GBybAMgtwlmC0GHbU//FIXV6ixs1/Y?= =?Windows-1252?Q?MVu+UIqv8CwDKqnMXarSQtOYCg7+VwDe9DOTJ2zc+FP/Q9A9wVPSPKeB?= =?Windows-1252?Q?sldUGSKolKLomM0jZ2svfrzSoxmuzFbkYAaZ2X8Wm25YvOItycczO/NO?= =?Windows-1252?Q?RVz33FvkrqlfcFSAyASOwyicuj5cWZxYrzCcVxsCuVUiojjO6oBalq9X?= =?Windows-1252?Q?OS2sgOciwXPPdX8PWmpWy4p6mCOHptfQPzhBKO1UL3TxmA91qhLjhDhc?= =?Windows-1252?Q?lhEz8vNRErixi5MPNjPGWatbXB26KvvA9PQVR8Q2O1T1Bv9uR6K5l90v?= =?Windows-1252?Q?uVHPNZfNt8dqRvLEay1cr/64ZJ+kULmgnU5pnYP7ti7XFc/kLUKTVOSG?= =?Windows-1252?Q?VlFQU6pmzZIdtc/4OHqUX/oz9zTBZ9BFXF5NkoMjw9UiuHwBrr07MJMx?= =?Windows-1252?Q?xPorECvPF/4Ly+YbJQV8+OsEeVf?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2379; 6:rOvplD6sydri6ro6ylKpnBrrmYKbmfDhMzN4AmzduDeUYlAMpM3NR2hC0M/6Q6r/md8OqxmHXaXUr1ph7SbFaddP1dXjAGYU9XDUrHDqq8VFzxCLLTlEq1eoNZBeZMM4sJbkq0/mpmqxPdre6BlfxA9tujh+oaeBLK9yJZnMbk5l4vuyltDkSU3LdqRIxxvVJCGDiOaOZopgPy0Vzl6o4kOyjJNEDk1lE3Cz4X66HJ7TVOZhEg91FWOya5S+Kq1WZ3Y0qqW51XRyDqx3NBCDazg19qugDZvs2DfbSUXbFc8=; 5:zqzxOsRBoqQaKgNqMXpLuxmCkS+QyyOvwgYTudFEj1DRhBWdTZB4IccRH8UXkAKSGE/KGffqD9Y6HkYuuR+tPvOS1QwPI35KNt31Sqi2I49TUHAUDbFNRhDFacvnD4uZ+IIIYeL77B3Bl80uRArr7ReIcY/QM2Yv9rSGOkk9ejg=; 24:r7AB2bMmToE2F8Z39DoJzVcZ0Uvf/PArLaSKrXguyt7WnZPyi1iPf/O0BeT4iF72ACPIXQRQEvXD74JYBaDF1+fEKuiYPuUz3zMCifZnKeU=; 7:8ev9HfYNoWpaq0MobBLLRPw4nHNXje7f5yjwGXcesOZcqpAqt+qCs/UsMHVHjvFGEFIzMXalSkKrh6wFj2jYfef0DQstXrUaeZrv7CnTPw1jiw0VObFqjHTkrEu12COHuA/eKCJbE5+ak0if45mgC+80U+z3l4/fpC5pFXJEakVI2Y47spPwJneTJMXNnHEJKvFQ8IYcKoVicxkirj79XO9E25KdWZ8yaCPqK/sQ94fGestdG1gXZ1nsn7AT7FOd SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2016 12:31:01.8033 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2379 Subject: Re: [dpdk-dev] [PATCH v4 00/17] prepare for rte_device / rte_driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 12:31:04 -0000 Self NACK. Rebase over master before posting series broke compilation. Apologies. On Tuesday 21 June 2016 05:32 PM, Shreyansh Jain wrote: > * Original patch series is from David Marchand [1], [2]. > * Cover letter text has been modified to make it author agnostic > > David created the original patchset based on the discussions on list [3]. > Being a large piece of work, this patchset introduces first level of changes > for generalizing the driver-device relationship for supporting hotplug. > > Pending work, as per discussions in thread [3]: > - Heirarchical relationship between rte_driver/device, pci_*, crypto_* > - Cleaner device init/deinit methods (probably from rte_driver onwards) > - Moving generic flags/fields from pci_* structure to rte_* structure > - Removing dependency on devargs for pdev/vdev distinction > - Device/Driver lists: discussion and decision on separate or unified lists > > Changes since v3: > - rebase over HEAD (913154e) > - Update arguments to RTE_EAL_PCI_REGISTER macro as per Jan's suggestion > - modify qede driver to use RTE_EAL_PCI_REGISTER > - Argument check in hotplug functions > > Changes since v2: > - rebase over HEAD (d76c193) > - Move SYSFS_PCI_DRIVERS macro to rte_pci.h to avoid compilation issue > > Changes since v1: > - rebased on HEAD, new drivers should be okay > - patches have been split into smaller pieces > - RTE_INIT macro has been added, but in the end, I am not sure it is useful > - device type has been removed from ethdev, as it was used only by hotplug > - getting rid of pmd type in eal patch (patch 5 of initial series) has been > dropped for now, we can do this once vdev drivers have been converted > > [1] http://dpdk.org/ml/archives/dev/2016-January/032387.html > [2] http://dpdk.org/ml/archives/dev/2016-April/037686.html > [3] http://dpdk.org/ml/archives/dev/2016-January/031390.html > > David Marchand (17): > pci: no need for dynamic tailq init > crypto: no need for a crypto pmd type > drivers: align pci driver definitions > eal: remove duplicate function declaration > eal: introduce init macros > crypto: export init/uninit common wrappers for pci drivers > ethdev: export init/uninit common wrappers for pci drivers > drivers: convert all pdev drivers as pci drivers > crypto: get rid of crypto driver register callback > ethdev: get rid of eth driver register callback > eal/linux: move back interrupt thread init before setting affinity > pci: add a helper for device name > pci: add a helper to update a device > ethdev: do not scan all pci devices on attach > eal: add hotplug operations for pci and vdev > ethdev: convert to eal hotplug > ethdev: get rid of device type > > app/test/virtual_pmd.c | 2 +- > drivers/crypto/qat/rte_qat_cryptodev.c | 18 +- > drivers/net/af_packet/rte_eth_af_packet.c | 2 +- > drivers/net/bnx2x/bnx2x_ethdev.c | 35 +--- > drivers/net/bonding/rte_eth_bond_api.c | 2 +- > drivers/net/cxgbe/cxgbe_ethdev.c | 24 +-- > drivers/net/cxgbe/cxgbe_main.c | 2 +- > drivers/net/e1000/em_ethdev.c | 16 +- > drivers/net/e1000/igb_ethdev.c | 40 +---- > drivers/net/ena/ena_ethdev.c | 20 +-- > drivers/net/enic/enic_ethdev.c | 23 +-- > drivers/net/fm10k/fm10k_ethdev.c | 23 +-- > drivers/net/i40e/i40e_ethdev.c | 26 +-- > drivers/net/i40e/i40e_ethdev_vf.c | 25 +-- > drivers/net/ixgbe/ixgbe_ethdev.c | 47 +---- > drivers/net/mlx4/mlx4.c | 22 +-- > drivers/net/mlx5/mlx5.c | 21 +-- > drivers/net/mpipe/mpipe_tilegx.c | 2 +- > drivers/net/nfp/nfp_net.c | 23 +-- > drivers/net/null/rte_eth_null.c | 2 +- > drivers/net/pcap/rte_eth_pcap.c | 2 +- > drivers/net/qede/qede_ethdev.c | 40 +---- > drivers/net/ring/rte_eth_ring.c | 2 +- > drivers/net/szedata2/rte_eth_szedata2.c | 25 +-- > drivers/net/vhost/rte_eth_vhost.c | 2 +- > drivers/net/virtio/virtio_ethdev.c | 26 +-- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 23 +-- > drivers/net/xenvirt/rte_eth_xenvirt.c | 2 +- > examples/ip_pipeline/init.c | 22 --- > lib/librte_cryptodev/rte_cryptodev.c | 67 ++----- > lib/librte_cryptodev/rte_cryptodev.h | 2 - > lib/librte_cryptodev/rte_cryptodev_pmd.h | 45 ++--- > lib/librte_cryptodev/rte_cryptodev_version.map | 9 +- > lib/librte_eal/bsdapp/eal/eal_pci.c | 52 +++++- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 + > lib/librte_eal/common/eal_common_dev.c | 47 +++++ > lib/librte_eal/common/eal_common_pci.c | 19 +- > lib/librte_eal/common/eal_private.h | 20 ++- > lib/librte_eal/common/include/rte_dev.h | 29 +++- > lib/librte_eal/common/include/rte_eal.h | 3 + > lib/librte_eal/common/include/rte_pci.h | 36 ++++ > lib/librte_eal/common/include/rte_tailq.h | 4 +- > lib/librte_eal/linuxapp/eal/eal.c | 7 +- > lib/librte_eal/linuxapp/eal/eal_pci.c | 16 +- > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 + > lib/librte_ether/rte_ethdev.c | 222 +++++------------------- > lib/librte_ether/rte_ethdev.h | 40 ++--- > lib/librte_ether/rte_ether_version.map | 4 +- > 48 files changed, 395 insertions(+), 750 deletions(-) >