From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 711DAC35C for ; Tue, 21 Jun 2016 15:41:44 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 21 Jun 2016 06:41:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,504,1459839600"; d="scan'208";a="980394662" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.90]) ([10.237.220.90]) by orsmga001.jf.intel.com with ESMTP; 21 Jun 2016 06:41:41 -0700 To: Jerin Jacob , dev@dpdk.org References: <1465931200-23912-1-git-send-email-jerin.jacob@caviumnetworks.com> <1466170194-28393-1-git-send-email-jerin.jacob@caviumnetworks.com> <1466170194-28393-5-git-send-email-jerin.jacob@caviumnetworks.com> Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com, Maciej Czekaj , Kamil Rytarowski , Zyta Szpak , Slawomir Rosek , Radoslaw Biernacki From: Ferruh Yigit Message-ID: <57694413.2010901@intel.com> Date: Tue, 21 Jun 2016 14:41:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1466170194-28393-5-git-send-email-jerin.jacob@caviumnetworks.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v6 04/27] net/thunderx/base: add mbox APIs for PF/VF communication X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 13:41:44 -0000 On 6/17/2016 2:29 PM, Jerin Jacob wrote: > DPDK nicvf driver doesn't have access to NIC's PF address space. > Introduce a mailbox mechanism to communicate with PF driver through > shared 128bit register interface. > > Signed-off-by: Jerin Jacob > Signed-off-by: Maciej Czekaj > Signed-off-by: Kamil Rytarowski > Signed-off-by: Zyta Szpak > Signed-off-by: Slawomir Rosek > Signed-off-by: Radoslaw Biernacki ... > + > +static inline const char * > +nicvf_mbox_msg_str(int msg) > +{ > + assert(msg >= 0 && msg < NIC_MBOX_MSG_MAX); > + /* undefined messages */ > + if (mbox_message[msg] == NULL) > + msg = 0; > + return mbox_message[msg]; > +} With clang getting following compile error: == Build drivers/net/thunder CC nicvf_mbox.o /root/development/dpdk-next-net/drivers/net/thunderx/base/nicvf_mbox.c:68:1: error: unused function 'nicvf_mbox_msg_str' [-Werror,-Wunused-function] nicvf_mbox_msg_str(int msg) ^ 1 error generated. /root/development/dpdk-next-net/mk/internal/rte.compile-pre.mk:126: recipe for target 'nicvf_mbox.o' failed It looks like nicvf_mbox_msg_str() only called within logging functions which can depends on DEBUC_X config options. Regards, ferruh