From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 318F28D8D for ; Tue, 21 Jun 2016 18:42:36 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 21 Jun 2016 09:42:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,505,1459839600"; d="scan'208";a="832543923" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.90]) ([10.237.220.90]) by orsmga003.jf.intel.com with ESMTP; 21 Jun 2016 09:42:31 -0700 To: Nelio Laranjeiro , dev@dpdk.org References: <1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com> <1466493818-1877-1-git-send-email-nelio.laranjeiro@6wind.com> From: Ferruh Yigit Message-ID: <57696E75.8050402@intel.com> Date: Tue, 21 Jun 2016 17:42:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1466493818-1877-1-git-send-email-nelio.laranjeiro@6wind.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 00/25] Refactor mlx5 to improve performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 16:42:36 -0000 On 6/21/2016 8:23 AM, Nelio Laranjeiro wrote: > Enhance mlx5 with a data path that bypasses Verbs. > > The first half of this patchset removes support for functionality completely > rewritten in the second half (scatter/gather, inline send), while the data > path is refactored without Verbs. > > The PMD remains usable during the transition. > > This patchset must be applied after "Miscellaneous fixes for mlx4 and mlx5". > > Changes in v3: > - Rebased patchset on top of next-net/rel_16_07. > > Changes in v2: > - Rebased patchset on top of dpdk/master. > - Fixed CQE size on Power8. > - Fixed mbuf assertion failure in debug mode. > - Fixed missing class_id field in rte_pci_id by using RTE_PCI_DEVICE. > > Adrien Mazarguil (8): > mlx5: replace countdown with threshold for Tx completions > mlx5: add debugging information about Tx queues capabilities > mlx5: check remaining space while processing Tx burst > mlx5: resurrect Tx gather support > mlx5: work around spurious compilation errors > mlx5: remove redundant Rx queue initialization code > mlx5: make Rx queue reinitialization safer > mlx5: resurrect Rx scatter support > > Nelio Laranjeiro (16): > drivers: fix PCI class id support > mlx5: split memory registration function > mlx5: remove Tx gather support > mlx5: remove Rx scatter support > mlx5: remove configuration variable > mlx5: remove inline Tx support > mlx5: split Tx queue structure > mlx5: split Rx queue structure > mlx5: update prerequisites for upcoming enhancements > mlx5: add definitions for data path without Verbs > mlx5: add support for configuration through kvargs > mlx5: add Tx/Rx burst function selection wrapper > mlx5: refactor Rx data path > mlx5: refactor Tx data path > mlx5: handle Rx CQE compression > mlx5: add support for multi-packet send > > Yaacov Hazan (1): > mlx5: add support for inline send > Patchset applies and compiles fine, thanks. But still has some checkpatch warnings, -btw, I am using the checkpatch script from latest master branch of Linux repo. Following is the sample type of warnings (not instances, there are more than one instance per type): WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #112: FILE: drivers/net/mlx5/mlx5_mr.c:65: + unsigned mem_idx) WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #288: FILE: drivers/net/mlx5/mlx5_mr.c:241: + * pointer is valid. */ WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL) #524: FILE: drivers/net/mlx5/mlx5_txq.c:265: + return EINVAL; WARNING:LONG_LINE: line over 80 characters #108: FILE: drivers/net/mlx5/mlx5_ethdev.c:1250: + txq_ctrl->txq.stats.idx = primary_txq->stats.idx; WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const #88: FILE: drivers/net/mlx5/mlx5.c:281: + static const char *params[] = { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #218: FILE: drivers/net/mlx5/mlx5_rxtx.c:92: + if (!ret || !(ret = ((*buf)[i] == magic[i]))) CHECK:SPACING: spaces preferred around that '&' (ctx:VxV) #414: FILE: drivers/net/mlx5/mlx5_rxtx.c:625: + (uintptr_t)&(*rxq->cqes)[rxq->cq_ci & ^ WARNING:INDENTED_LABEL: labels should not be indented #520: FILE: drivers/net/mlx5/mlx5_rxtx.c:789: + skip: