From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f48.google.com (mail-lf0-f48.google.com [209.85.215.48]) by dpdk.org (Postfix) with ESMTP id AABD6C30A for ; Wed, 22 Jun 2016 10:19:08 +0200 (CEST) Received: by mail-lf0-f48.google.com with SMTP id f6so65251318lfg.0 for ; Wed, 22 Jun 2016 01:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=mg9t3wsPcAwJSTZOk7Ocffh9fQzjSnIl1Xa4NMirzDY=; b=aPJzAxa/GOLdmJ/XHe1n1mSUdi5K6UxOfLeBAO+ETBc2gjHlkceMRqI1LGF05aSMAh nCH53mYVim+lv2w4EpbtsTrS3ZWP9aBsgtIp19BWoED3acRYiSCXviuKvvoDiOk79kQY 0nBtuuhVsjDQ0nERW+DKC07Y+ctnR8sI2veWXH2s7Ai5p+YhTF8o0tZsdgb5EPS5Ig7F i1ZYTdXlXOEn0zl3pXtIrn79a2CeMMmw58Y/c/VVYj5Z/0Lo/Jti8kmZYj3bgw9kqSHY br35p4oyhVy9CX/kFZGx9AcveN0U6HPsB4wNQt9q5qCXtu4TmfXHk9+jdGVg+vqNm7xE A/Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=mg9t3wsPcAwJSTZOk7Ocffh9fQzjSnIl1Xa4NMirzDY=; b=Xl0dfFOBhZEQeroRExy/krYDMVn7eWxGaqVp2XaM4AGvPNZV4Ud8/AwoLFIB+gISSo rx3FOilKXqPqDYNtAEjh5bx0C751cMKzW2wM0WFBGEvop1IoimeO4r9hqgjMl1mgDGw/ QIzgEEvUTvHGqeVLQXaodoowe7MwdiEGDHDRPjL9N862m4xRespbqDsz/MJ5xGkrT63Y xUhDE6ND31tAH2qWLbxXxz86hgRKQDGUmrZ/fnc92JZS9apZ6+53cBgnieJCRSwKeErm +gb4E+nVt378vyD7GktmKowuiYKURjJULemX95MarPSy95gThSLQwtPahNiEpArTHEhr Baqw== X-Gm-Message-State: ALyK8tL+ttCwI/+Uqp4c9sbdECiSkvuZ5xFGoFZ+43CgPDm6mPb/Py7cSpv2VS82YldP2w== X-Received: by 10.25.207.15 with SMTP id f15mr6124557lfg.108.1466583548361; Wed, 22 Jun 2016 01:19:08 -0700 (PDT) Received: from [10.0.2.212] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.googlemail.com with ESMTPSA id 16sm6052807ljj.47.2016.06.22.01.19.07 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Jun 2016 01:19:07 -0700 (PDT) To: Thomas Monjalon References: <1464767771-19159-1-git-send-email-zr@semihalf.com> <575ED666.2010509@intel.com> <1667158.opORKPN5aG@xps13> <57690F01.6020600@semihalf.com> Cc: Remy Horton , dev@dpdk.org From: Zyta Szpak Message-ID: <576A49FC.2090400@semihalf.com> Date: Wed, 22 Jun 2016 10:19:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <57690F01.6020600@semihalf.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 08:19:08 -0000 Note that if we remove rte_eth_dev_get_reg_length() then it will break all of the drivers that implement it. Shall I remove it all leave it and modify only ethtool to use rte_eth_dev_get_regs() to get reg size? In the end the drivers will have to implement the part of setting the size in reg_info struct. rte_eth_dev_get_regs() itself wouldn't change at all. Or do you have different opinion? On 21.06.2016 11:55, Zyta Szpak wrote: > OK, I will do the v4. > > On 17.06.2016 12:20, Thomas Monjalon wrote: >> 2016-06-13 16:51, Remy Horton: >>> On 12/06/2016 15:51, Zyta Szpak wrote: >>>> I would prefer having only one function rte_eth_dev_get_regs() >>>> which returns length and width if data is NULL. >>>> The first call is a parameter request before buffer allocation, >>>> and the second call fills the buffer. >>>> >>>> We can deprecate the old API and introduce this new one. >>>> >>>> Opinions? >>>> >>>> In my opinion as it is now it works fine. Gathering all parameters in >>>> one callback might be a good idea if the maintainer also agrees to >>>> that >>>> because as I mentioned, it interferes. >>> From my perspective changing rte_eth_dev_get_regs() isn't a >>> problem, as >>> it isn't used directly rather than through rte_ethtool_get_regs().. >> Zyta, would you like to make a v4? >